Evan Wallace

Results 542 comments of Evan Wallace

> Is this an issue where enum resolution comes after parsing/constant folding? Yes that’s correct, at least for cross-file enum inlining.

That's up to you really. It sounds like you have custom requirements so you might need something custom. For example, you could use a library such as https://github.com/browserify/resolve that I...

You never really said why you're trying to do what you're asking for, so I'm not exactly sure what to recommend. If you need something custom that can tweak various...

FWIW a hack to use here that would likely work fine in the vast majority of cases without actually resolving the intermediate path to the package could be to resolve...

I'm not sure this specific direction (adding bun-specific stuff to esbuild's node target) makes sense because that target is for node, not bun.

I'm not sure if this will work for you, but FYI esbuild already has an API to mark things as external: https://esbuild.github.io/api/#external. Specifically `--external:bun:* --external:bun` will mark `bun` as external...

Using an `import` statement matches the `import` condition, not the `require` condition. If you want to match the `require` condition instead then you should use `require` instead of `import`: ```js...

This problem is caused by Windows not supporting relative paths between drives. Yarn avoids this with a hack where they pretend that relative paths between drives are allowed, while esbuild...

Can you provide a way to reproduce the issue? Specific instructions to follow or a repository with sample code would work.

Isn't that what [`--packages=external`](https://esbuild.github.io/api/#packages) is for? Why not use that? Alternatively, why aren't you doing `--external:request` if `request` is the problematic package? It sounds like this problem has to do...