Evan Wallace

Results 542 comments of Evan Wallace

Thanks! I updated my branch, which now appears to be working correctly in all of these cases. So it seems like it's ready for people to try out. I'm planning...

> This might be a separate issue, but is there any way the plugin API could get access to assertion metadata? No. The specification forbids import assertions from triggering any...

FYI I'm planning on releasing a form of this sometime soon, but built into esbuild instead. You can see my work in progress version here: #2508.

Speedscope is one of my test cases for esbuild so this should work fine. The command is something like this: ``` esbuild src/speedscope.tsx --bundle --minify --define:process.env.NODE_ENV=\"production\" ``` Let me know...

> but I imagine this `Rec || (Rec = {})` expression is there for a reason That's for enum declaration merging. FWIW that's easy to solve for too: https://github.com/microsoft/TypeScript/issues/27604#issuecomment-477595023. You...

This is unfortunate. I didn't include the errors here because esbuild can potentially generate hundreds of errors and I didn't want the exception string to ever be huge. The errors...

> maybe allow the `transform` API to pass in a filename too? Just saw this, sorry. This option already exists and is called `sourcefile`.

Is it planned for this to work with TypeScript types as well as values? For example, I'd expect the following to be valid as well: ```ts import type { 'a'...

This problem is most definitely **not** fixed. Here's the same demonstration of the broken behavior from the original post with all versions updated to the latest versions. This demonstrates that...