Evan Shortiss

Results 85 comments of Evan Shortiss

Unfortunately it appears not with Joi v16. One potential solution is that the 3.x release line of this module could support Joi v15. I think it should be possible to...

@danielbrauer, works for me. Did you `rm -rf node_modules` and reinstall? I started with a fresh project: ``` # setup new project cd /tmp mkdir joi-test cd joi-test npm init...

@danielbrauer and the resulting package.json was: ```json { "name": "joi-test", "version": "1.0.0", "description": "", "main": "index.js", "scripts": { "test": "echo \"Error: no test specified\" && exit 1" }, "keywords": [],...

Good catch. This one isn't too bad to fix. Here's the fix in [mainline 3.x](https://github.com/evanshortiss/express-joi-validation/blob/3.x/express-joi-validation.d.ts#L27-L29). I think using this might be better: ```ts export interface ExpressJoiError extends Joi.ValidationResult { type:...

@danielbrauer correct, but the reason for this 3.x release is to support joi-extract-type which requires Joi v15. So all Joi deps need to be 15.x variants

Whoops. I saw this ages ago and let it slip. Celebrate does look like a good option TBH. Well maintained and sponsored 👍 Migrating looks like it would be pretty...

Thanks @th1nkful. Merged and released, thanks for the help 👍 @Neboer, I've taken a quick look at Celebrate. Seems like it's easy to replace this library with it for JavaScript...

Noted in https://github.com/openshift/openshift-docs/issues/47702

@PizzaPartyInc (great username BTW), can you expand on why you need this feature? I'm leaning towards thinking this isn't a problem for env-var to solve. I would generally expect variable...

@dougwilson @ajfranzoia @danieljuhl @devlato thoughts on #3100?