prolink-tools icon indicating copy to clipboard operation
prolink-tools copied to clipboard

Add firewall hint to ConnectingSplash

Open FunctionDJ opened this issue 3 years ago • 6 comments

FunctionDJ avatar Oct 18 '22 10:10 FunctionDJ

Someone is attempting to deploy a commit to a Personal Account owned by @evanpurkhiser on Vercel.

@evanpurkhiser first needs to authorize it.

vercel[bot] avatar Oct 18 '22 10:10 vercel[bot]

@evanpurkhiser Can you comment on why you've closed this PR?

FunctionDJ avatar Feb 27 '23 22:02 FunctionDJ

oops, this looks like an accident

evanpurkhiser avatar Feb 27 '23 22:02 evanpurkhiser

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
prolink-tools ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Feb 27, 2023 at 10:41PM (UTC)

vercel[bot] avatar Feb 27 '23 22:02 vercel[bot]

The reason I generally haven't merged this yet is

  1. This is already docuemnted in the manuals troubleshooting section, which the current message links too.
  2. I haven't had a chance to look at how the text looks with this in it. If you could attach a screenshot that would be helpful!

evanpurkhiser avatar Feb 27 '23 22:02 evanpurkhiser

I'll see if i can provide a screenshot soon. I noticed that the troubleshooting section recommends to disable the firewall instead of allowing the app through it. I don't think it's a good idea to recommend this to users without further context.

FunctionDJ avatar Feb 27 '23 22:02 FunctionDJ