Evan Miller

Results 234 comments of Evan Miller

Builds and tests OK with `-latomic` and without the `-march=core2` flag. It's possible the latter flag is implicit when GCC is compiling on x86_64 / Darwin.

Sure. Are we OK passing `-latomic` to clang? Keep or chuck the `-march` flags?

@catap I think libatomic only ships with GCC. On a stock system running clang I get `ld: library not found for -latomic`. So we'll need to find a branch point...

Just the peanut gallery here, but can you explain why the `static_assert_size` calls have been removed? Edit: Sorry, I misread the PR. Coffee still kicking in...

A quick note about the "filler". SAS files are organized into a "header" followed by 1 or more "pages". By default haven will write a header of size 1024 bytes...

@rogerjdeangelis Nice detective work!

Hi, I have put together a pre-release here: https://github.com/WizardMac/ReadStat/releases/tag/v1.1.8-rc0

@mnizol It will be useful to know if this file is opened successfully by other packages e.g. Python sas7bdat. Technical notes for myself: The decompression is tripping up on the...