志宇

Results 288 comments of 志宇

For the commit message, remember to put a new line between first line and body.

It seems that you intended the sync flow to be: 1. Copy the wallet's `TxGraph` and pass it to the chain source. 2. Perform update, and populate `TxGraph` with missing...

@LagginTimes thanks for cleaning it up!

> What do you see as the next logical step to improving the electrum crate, for example in relation to [Rearchitect `bdk_electrum` syncing/scanning. #1332](https://github.com/bitcoindevkit/bdk/issues/1332) and [Option for Electrum and Esplora...

A test to see whether fee is actually calculated will be even better.

This needs a rebase, merging #1203 broke this.

@LLFourn's [comment](https://github.com/bitcoindevkit/bdk/issues/1396#issuecomment-2036248375)... > `None` would be in no ones mempool (not even yours). You can have a transaction that is valid but has never left application memory. summarizes the main...

Another priority review for next week.

> This fixes an issue where unbroadcast and otherwise non-canonical transactions were returned from methods How would a non-canonical tx be returned by the methods?

I feel like we should include a method for returning "unseen and unanchored" transactions. Not sure what to name it, maybe `unseen_txs` is enough? I guess this would be on...