sonus icon indicating copy to clipboard operation
sonus copied to clipboard

Published 20 hours ago • verified publisher icon evancohen

WIP: Add tests for future refactoring

Open joyarzun opened this issue 7 years ago • 4 comments

Hi there. I want to add tests for future refactoring and not breaking anything. The idea is refactoring to isolate the recognizer code and be able to add others streaming services. This is a WIP to know whether it's the right way or not. It's my first time making mocks of Stream. What do you think?

joyarzun avatar Jul 18 '17 03:07 joyarzun

Sounds like a good idea to me! @ashishsc?

evancohen avatar Jul 20 '17 04:07 evancohen

lgttm ! thanks @joyarzun

ashishsc avatar Jul 20 '17 17:07 ashishsc

Jumped the gun there a little bit, pretty sure this is work in progress. You must really want tests ;)

evancohen avatar Jul 20 '17 22:07 evancohen

woops. I meant to say lgtm to keep going forward = )

ashishsc avatar Jul 24 '17 02:07 ashishsc