skyland-beta icon indicating copy to clipboard operation
skyland-beta copied to clipboard

Crash on pressing retry after losing

Open tolik518 opened this issue 2 years ago • 6 comments

So I was playing in adventure mode on easy and ws losing this fight against a pirate ship (on second stage) and when I was promted to retry the game crashed for me.

Fatal error makes sad

Bressing B have sadly not worked. So I had to restart the game - and was able to recover the save game :)

Is there a way to get a more verbose error next time to be able to share it?

tolik518 avatar Mar 22 '23 12:03 tolik518

Thanks for reporting this! Yeah for fatal errors, the game keeps a backup save in memory and writes it upon crashes, so you're able to recover. This particular error is pretty unusual, I will have to add some more verbose logging.

I know where in the code the issue happened, based on the error message https://github.com/evanbowman/skyland-beta/blob/master/source/skyland/scene/rewindScene.cpp#L1056. I just need to do some testing to figure out how the game could end up in this state.

Cool gameboy!

evanbowman avatar Mar 22 '23 13:03 evanbowman

At the very least, I can give players the option to retry the level from the beginning if an error like this occurs during rewinding.

evanbowman avatar Mar 22 '23 13:03 evanbowman

Ok! Until I can figure out what went wrong, I created a patch to allow you to retry a level upon fatal errors without restarting the game.

evanbowman avatar Mar 22 '23 14:03 evanbowman

Thanks a lot for looking into it and for fixit it so fast!

I love the game a lot so far - I'm have followed the development for some months now and I was wondering if it's ok to open tickets for feature requests or potential improvements?

tolik518 avatar Mar 22 '23 16:03 tolik518

Yes of course! I encourage you to do so; any feedback you have could be useful to me for improving the game.

evanbowman avatar Mar 22 '23 17:03 evanbowman

Thank you, I will open some tickets in the following days :)

tolik518 avatar Mar 22 '23 17:03 tolik518

I've made so many changes since this issue was created, that I'm unsure if it's worth trying to reproduce this issue again. I'm cleaning up old issues and I'm going to close this one, as I haven't been able to reproduce the problem for a long time and I may have unknowingly fixed it at some point.

evanbowman avatar Nov 09 '24 19:11 evanbowman