logrus_sentry Compile error after braking change in pkg/errors

Hiiiiiii

Today a breaking change in github.com/pkg/errors package was merged which changes type for errors.Frame from a simple program counter to runtime.Frame.

github.com/evalphobia/logrus_sentry/sentry.go:314:16 cannot convert stFrames[i] (type "github.com/pkg/errors".Frame) to type uintptr

I will work on a MR right away

Jan 05 '19 17:01 arcana261

Is https://github.com/pkg/errors/issues/188 related to this? As it looks like related PR https://github.com/pkg/errors/pull/183 has just been merged.

Jan 06 '19 01:01 mexisme

@mexisme Yes dear good sir..

Jan 06 '19 05:01 arcana261

@arcana261 Thanks 🍡 #75 has been Merged. https://github.com/evalphobia/logrus_sentry/releases/tag/v0.7.0

Jan 09 '19 02:01 evalphobia

OMG They've done it again :'( :'( :'(

Jan 09 '19 09:01 arcana261

I've again submitted another PR #76 which reverts us to using just PC's.

Jan 09 '19 09:01 arcana261