ev3dev-lang icon indicating copy to clipboard operation
ev3dev-lang copied to clipboard

Some typo on the driver docs

Open a1aw opened this issue 9 years ago • 3 comments

Hi,

I found out some typo in the following document: http://www.ev3dev.org/docs/sensors/hitechnic-nxt-color-sensor/ , whereas vendor_id would be HiTechnic instead of HiTechnc.

I am not quite sure about it, but I think it is HiTechnic

Regards, mob41

a1aw avatar Oct 12 '16 11:10 a1aw

HiTechnc is consistently used as a vendor_id throughout this file (it is used to generate the page you linked): https://github.com/ev3dev/lego-linux-drivers/blob/master/sensors/nxt_i2c_sensor_defs.c. So this could be the intended value.

ddemidov avatar Oct 12 '16 11:10 ddemidov

Also, vendor_id is defined as char[NXT_I2C_ID_STR_LEN + 1], where NXT_I2C_ID_STR_LEN is 8. So HiTechnic simply does not fit into vendor_id

ddemidov avatar Oct 12 '16 11:10 ddemidov

Just a suggestion: Can this be told at the docs? So the users won't be confused with HiTechnc

a1aw avatar Oct 18 '16 05:10 a1aw