Evgeni Burovski

Results 624 comments of Evgeni Burovski

@Kai-Striega looking into it. Using this tweak ```diff diff --git a/scipy/interpolate/_rgi_cython.pyx b/scipy/interpolate/_rgi_cython.pyx index b85fb571b4..717924ed88 100644 --- a/scipy/interpolate/_rgi_cython.pyx +++ b/scipy/interpolate/_rgi_cython.pyx @@ -124,7 +124,7 @@ def evaluate_linear(values, indices, norm_distances, out_of_bounds): @cython.wraparound(False) [email protected](False)...

OK, scratch my previous comment. Here's I think what happens: - `find_indices_ascending` already does `i[i < 0] = 0 ; i[i > grid.size - 2] = grid.size - 2` dance....

> The remaining test failures are in nan handling --- which again will need to be special-cased Done: the tip of this branch https://github.com/ev-br/scipy/commits/rgi_cython now passes all tests locally. Would...

What would be your approach to evaluate_linear? I'd probably start from an explicit evaluator for 2D, just to get a feel for both code and performance, and postpone writing a...

Yes, it's a tough one. There is some prior art in the NdPPoly class, not sure if it's best, but it's at least some. If push really comes to shove,...

1. Can you construct the knot vector once (copy-paste private finctions _not_a_knot/_augknt, both are trivial) and feed it to make_interp_spline(..., t=t)? 2. We had a discussion of whether make_interp_spline should...

Am circling back to this now. What we can do is to refactor `make_interp_spline` into a wrapper over two leading-underscore functions, roughly `_make_interp_knots(x, k, bc_type)` and `_make_interp_coefs(x, y, t, k,...

Indeed, these arguments are missing in my rough sketch above, should be added where needed in the real implementation. So if it's helpful for dask, PR is welcome (will review...

OK, doctests should be fixed now, the `_stats.pyx` failure is very much unrelated. So reviewing this should be safe now. If there are further doctest failures, I'll fix them up...

Thanks Matt! Re splitting it --- and yes this needs splitting --- I'm not very up-to-date of our infrastructure for multiple rst pages. It used to be basically a single...