Evgeni Burovski
Evgeni Burovski
Makes sort of sense but that's not the final answer still. The ValueError is reasonable: s is too small. However it's a bit worrying that s=1 gives some answer and...
What is the status here, folks, is this ready to land or is there something to address still?
> test_negative (there is a TODO about uints) The TODO is `# TODO: clarify if uints are acceptable, adjust accordingly` and apparently negative(uint) wraps around in at least several libraries:...
cross-ref https://github.com/data-apis/array-api-tests/pull/324 for testing `reciprocal` and `cumulative_prod`.
https://github.com/data-apis/array-api-tests/pull/347 adds a test for `count_nonzero`
We now officially have the 2024.12 test coverage. At least all new functions are covered, with remaining TODOs tracked in gh-301 and gh-364.
- ISTM that `clip` is most similar to `where`. - `nextafter` with mixed dtypes, agreed it's similar to `less` and `greater` - `__setitem__` should probably behave similar to inplace `__iadd__`...
Tried giving this PR a spin (pun intended): ``` (scipy-dev) ev-br@qgpu3:~/repos/scipy$ git clean -xdf Removing .spin/__pycache__/ (scipy-dev) ev-br@qgpu3:~/repos/scipy$ pip install spin Collecting spin Using cached spin-0.12-py3-none-any.whl.metadata (11 kB) Requirement already...
The problem for me is that just `$ spin build` error out (x86_64 Ubuntu Linux, conda env)
Using the spin branch, `$ spin build` and `$ spin test` seem to work, great! In general, I'm a big fat +1 for this PR; one reason is that it...