Evgeni Burovski
Evgeni Burovski
> I keep this in mind but won't look at it till we're closer to the end. Makes sense! Re ufuncs: you'll need to add an entry to functions.json, the...
Seems to work? ``` In [8]: from scipy.special._ufuncs import _log_iv_asym In [9]: _log_iv_asym([1, 2, 3], [2, 3, 5]) Out[9]: array([0.46121925, 0.80862499, 2.33515425]) ``` However, I'm not sure what is the...
One thing that stands out in a cursory look: there's a bunch of `int` and `unsigned int` variables. Are we sure this is 32-bit overflow safe? That's in Cython, which...
The CI failure in `FAILED scipy\optimize\tests\test__basinhopping.py::TestBasinHopping::test_all_nograd_minimizers` is surely unrelated. Now that gh-18926 is in, I think it might make sense to merge this one in the same release cycle.
Thank you for the review @h-vetinari ! Agreed on this stuff is indeed borderline voodoo. This whole PR is mostly janitorial too, so a janitorial review is great indeed. I...
Thanks Edgar! Merged in your edits.
A gentle ping @h-vetinari ; been a while, would you be able to take a look again at some point?
Thank you @h-vetinari ! Let me try a bit harder: I've taken out the `clang-format` reindent commit and squashed it down to 9 commits in total to - keep C/C++...
CI failure at https://github.com/scipy/scipy/actions/runs/9842093996/job/27170290925?pr=20519 is unrelated
Merging as approved. Thank you @h-vetinari for the review! And thanks to @andfoy and @Smit-create as co-authors.