Evgeni Burovski

Results 624 comments of Evgeni Burovski

Paused to run locally tests from `tests/cupy_tests` folder. There are several classes of errors (some working notes are below the fold), the largest source of noise is NEP50 and dtype...

cross-ref https://github.com/numpy/numpy/issues/26370 : https://github.com/cupy/cupy/pull/8314/commits/de98f8f12ae956349cb474ae041fff9044d59e36 works around it, might be able to drop the workaround

Curiously, `float16` arithmerics is broken under NumPy 2.0.0rc1. For instance, ``` (Pdb) p x array([4., 1., 1., 1., 9., 9., 9.], dtype=float16) (Pdb) p y array([4., 0., 5., 2., 0.,...

Decision needed: `numpy.in1d` emits DeprecationWarnings. https://github.com/cupy/cupy/pull/8314/commits/39cdc5365c350d0b91d0178a7c2189574c613ccb does this: - stop testing `cupy.in1d`, only test `cupy.isin` - keep `cupy.in1d` in the public API. - do we want `cupy.in1d` also emit DeprecationWarnings?...

Continued in https://github.com/cupy/cupy/pull/8531 : the rebase here is too messy, and I borked the branch. It's easier to send a new PR than to wrangle with git to salvage this...

Both dependencies are merged, the PR is rebased on main and is ready for review.

Sadly, no, I don't see this locally. `$ pytest tests/cupyx_tests/scipy_tests/interpolate_tests/ -v` passes for me (on CUDA 12 and scipy 1.13) modulo a test failure due to a unrelated scipy 1.13...

TBH, I don't see how a pure python addition of this PR can trigger this. The only possiblility is that a nan assignment is broken somehow, in this line: https://github.com/cupy/cupy/pull/8290/files#diff-e6ca1b203fa4c1b7e7f6170aa16844edb19aa250d65f43d99d4bd3ee26187b36R256...

makes me wonder if https://github.com/cupy/cupy/issues/7240 is related.