HLS Stream reconnect issue

[euzu]

HLS stream reconnect issue

@coderabbitai full review

Summary by CodeRabbit

• Refactor
  • Renamed internal flags and parameters for improved clarity in stream handling, including changes from "close_signal" to "continue_signal" and "continue_flag" to "reconnect_flag".
  • Enhanced naming consistency for reconnect logic in streaming components.
• New Features
  • Introduced a retry limit with backoff for stream reconnections, providing more robust handling of connection interruptions.
  • Added item type awareness to provider stream options for better stream management.
• Bug Fixes
  • EPG ID collection now processes only live channels, ensuring more accurate data handling.

[coderabbitai[bot]]

Walkthrough

This update primarily refactors naming conventions and control flow related to signaling and reconnect logic in streaming components. Across several modules, internal fields and parameters previously named for "close" or "continue" signaling are renamed for clarity, such as from close_signal to continue_signal and from continue_flag to reconnect_flag. The provider stream factory introduces a retry mechanism for reconnections, limiting attempts and handling specific HTTP errors. Additionally, EPG ID collection is now restricted to live channels by filtering on the xtream_cluster field. No changes were made to the overall logic or exported interfaces, except for renaming and minor additions.

Changes

File(s)	Change Summary
src/api/model/streams/buffered_stream.rs	Renamed all close_signal references to continue_signal in struct fields, methods, and logic checks.
src/api/model/streams/client_stream.rs	Renamed all close_signal references to continue_signal in struct fields, constructor, and internal usage.
src/api/model/streams/provider_stream_factory.rs	Refactored continue_flag to reconnect_flag; added retry logic for reconnections; updated method and field names; added item_type to options; improved naming for clarity.
src/processing/processor/epg.rs	Modified EPG ID collection to filter only channels with xtream_cluster == XtreamCluster::Live.

Sequence Diagram(s)

sequenceDiagram
    participant Client
    participant ProviderStreamFactory
    participant BufferedStream
    participant ClientStream
    participant AtomicOnceFlag

    Client->>ProviderStreamFactory: create_provider_stream()
    ProviderStreamFactory->>BufferedStream: new(reconnect_flag)
    BufferedStream->>ClientStream: new(continue_signal)
    ClientStream->>AtomicOnceFlag: check is_active()
    loop While reconnect_flag is active and retries remain
        ProviderStreamFactory->>ProviderStreamFactory: stream_provider()
        alt HTTP error (retryable)
            ProviderStreamFactory->>AtomicOnceFlag: check should_reconnect()
            ProviderStreamFactory->>ProviderStreamFactory: decrement retries
        else HTTP error (non-retryable) or retries exhausted
            ProviderStreamFactory->>AtomicOnceFlag: cancel_reconnect()
            ProviderStreamFactory->>Client: return None
        end
    end

Poem

In the code where the streams do flow,
Signals renamed for clarity’s glow.
Reconnect flags hop in, retries now in tow,
Only live channels for EPG we know.
With every refactor, our logic stays neat—
A rabbit’s proud hop, making streaming complete!
🐇✨

---

📜 Recent review details

Configuration used: CodeRabbit UI Review profile: CHILL Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 2d2d24fadca4fecb10d1d2a5d013b0a668aa3875 and cf7a1b8cc7516a7666f59de857934499ee86c5f3.

📒 Files selected for processing (1)

• src/api/model/streams/provider_stream_factory.rs (13 hunks)

🚧 Files skipped from review as they are similar to previous changes (1)

• src/api/model/streams/provider_stream_factory.rs

✨ Finishing Touches

• [ ] 📝 Generate Docstrings

---

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[aniel300]

could this have been causing the random buffer i experience from time to time?