euri10

Results 238 comments of euri10

the lint failing is because of black pin, do you want me to upgrade it @samuelcolvin in this PR or would prefer another ?

> happy to accept the change, but please can we update click or black or whatever to get tests passing? here it is

while you logout in tab1, tab2 is processing an endpoint is that the pattern ?

thinking out loud after I read [this](https://redis.readthedocs.io/en/stable/examples/asyncio_examples.html#Connecting-and-Disconnecting), shouldn't there be some close/aclose methods for stores, or at least one for the RedisStore ?

this can be circumvented in the get_app factory replacing the `RedisStore` with a `MemoryStore` only for tests but it feels like a hack

> > thinking out loud after I read [this](https://redis.readthedocs.io/en/stable/examples/asyncio_examples.html#Connecting-and-Disconnecting), shouldn't there be some close/aclose methods for stores, or at least one for the RedisStore ? > > I agree that...

> You could try though to manage its lifetime explicitly and see if that fixes the issue. something like this does work indeed, I'm not too sure this is not...

actually maybe if there is a way to lazily load the store, or use a lifespan-created redis client into the store that would be maybe cleaner, not sure...

> > actually maybe if there is a way to lazily load the store, or use a lifespan-created redis client into the store that would be maybe cleaner, not sure......

sounds good to me, I'm keen on tackling both, 1st one will be simpler and faster obviously