bpftime icon indicating copy to clipboard operation
bpftime copied to clipboard

fix: do not shift in map_by_fd

Open yunwei37 opened this issue 1 year ago • 2 comments

Description

The old version shift 32 bit in map_by_fd, we don't need to do that.

yunwei37 avatar Sep 02 '24 04:09 yunwei37

Codecov Report

Attention: Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.

Project coverage is 55.42%. Comparing base (9e35e28) to head (872ff64).

Files with missing lines Patch % Lines
runtime/src/bpftime_shm.cpp 0.00% 2 Missing :warning:
runtime/src/bpf_map/userspace/map_in_maps.hpp 0.00% 1 Missing :warning:
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #344      +/-   ##
==========================================
- Coverage   58.01%   55.42%   -2.59%     
==========================================
  Files         105       90      -15     
  Lines        7777     6538    -1239     
  Branches      839      544     -295     
==========================================
- Hits         4512     3624     -888     
+ Misses       3265     2914     -351     
Flag Coverage Δ
attach tests (uprobe & syscall trace) 97.52% <ø> (ø)
coverage-example-fedora-false-bashreadline-false ?
coverage-example-fedora-false-bashreadline-true ?
coverage-example-fedora-false-funclatency-false ?
coverage-example-fedora-false-funclatency-true ?
coverage-example-fedora-false-get_stack_id_example-false ?
coverage-example-fedora-false-get_stack_id_example-true ?
coverage-example-fedora-false-malloc-true ?
coverage-example-fedora-false-minimal-false ?
coverage-example-fedora-false-minimal-true ?
coverage-example-fedora-false-mountsnoop-true ?
coverage-example-fedora-false-opensnoop-libbpf-tools-true ?
coverage-example-fedora-false-opensnoop-true ?
coverage-example-fedora-false-sigsnoop-true ?
coverage-example-fedora-false-sslsniff-false ?
coverage-example-fedora-false-sslsniff-true ?
coverage-example-fedora-false-statsnoop-true ?
coverage-example-fedora-false-syscount-false ?
coverage-example-fedora-false-syscount-true ?
coverage-example-fedora-false-tailcall_minimal-true ?
coverage-example-fedora-false-usdt_minimal-false ?
coverage-example-fedora-false-usdt_minimal-true ?
coverage-example-fedora-true-bashreadline-false ?
coverage-example-fedora-true-bashreadline-true ?
coverage-example-fedora-true-funclatency-false ?
coverage-example-fedora-true-funclatency-true ?
coverage-example-fedora-true-get_stack_id_example-false ?
coverage-example-fedora-true-get_stack_id_example-true ?
coverage-example-fedora-true-malloc-true ?
coverage-example-fedora-true-minimal-false ?
coverage-example-fedora-true-minimal-true ?
coverage-example-fedora-true-mountsnoop-true ?
coverage-example-fedora-true-opensnoop-libbpf-tools-true ?
coverage-example-fedora-true-opensnoop-true ?
coverage-example-fedora-true-sigsnoop-true ?
coverage-example-fedora-true-sslsniff-false ?
coverage-example-fedora-true-sslsniff-true ?
coverage-example-fedora-true-statsnoop-true ?
coverage-example-fedora-true-syscount-false ?
coverage-example-fedora-true-syscount-true ?
coverage-example-fedora-true-tailcall_minimal-true ?
coverage-example-fedora-true-usdt_minimal-false ?
coverage-example-fedora-true-usdt_minimal-true ?
coverage-example-ubuntu-false-bashreadline-false ?
coverage-example-ubuntu-false-bashreadline-true ?
coverage-example-ubuntu-false-funclatency-false ?
coverage-example-ubuntu-false-funclatency-true ?
coverage-example-ubuntu-false-get_stack_id_example-false ?
coverage-example-ubuntu-false-get_stack_id_example-true ?
coverage-example-ubuntu-false-malloc-true ?
coverage-example-ubuntu-false-minimal-false ?
coverage-example-ubuntu-false-minimal-true ?
coverage-example-ubuntu-false-mountsnoop-true ?
coverage-example-ubuntu-false-opensnoop-libbpf-tools-true ?
coverage-example-ubuntu-false-opensnoop-true ?
coverage-example-ubuntu-false-sigsnoop-true ?
coverage-example-ubuntu-false-sslsniff-false ?
coverage-example-ubuntu-false-sslsniff-true ?
coverage-example-ubuntu-false-statsnoop-true ?
coverage-example-ubuntu-false-syscount-false ?
coverage-example-ubuntu-false-syscount-true ?
coverage-example-ubuntu-false-tailcall_minimal-true ?
coverage-example-ubuntu-false-usdt_minimal-false ?
coverage-example-ubuntu-false-usdt_minimal-true ?
coverage-example-ubuntu-true-bashreadline-false ?
coverage-example-ubuntu-true-bashreadline-true ?
coverage-example-ubuntu-true-funclatency-false ?
coverage-example-ubuntu-true-funclatency-true ?
coverage-example-ubuntu-true-get_stack_id_example-false ?
coverage-example-ubuntu-true-get_stack_id_example-true ?
coverage-example-ubuntu-true-malloc-true ?
coverage-example-ubuntu-true-minimal-false ?
coverage-example-ubuntu-true-minimal-true 20.54% <0.00%> (ø)
coverage-example-ubuntu-true-mountsnoop-true ?
coverage-example-ubuntu-true-opensnoop-libbpf-tools-true ?
coverage-example-ubuntu-true-opensnoop-true ?
coverage-example-ubuntu-true-sigsnoop-true ?
coverage-example-ubuntu-true-sslsniff-false ?
coverage-example-ubuntu-true-sslsniff-true ?
coverage-example-ubuntu-true-statsnoop-true ?
coverage-example-ubuntu-true-syscount-false ?
coverage-example-ubuntu-true-syscount-true ?
coverage-example-ubuntu-true-tailcall_minimal-true ?
coverage-example-ubuntu-true-usdt_minimal-false ?
coverage-example-ubuntu-true-usdt_minimal-true ?
runtime tests 53.11% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

:rocket: New features to boost your workflow:
  • :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

codecov[bot] avatar Apr 10 '25 17:04 codecov[bot]

⚠️ GitGuardian has uncovered 1 secret following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secret in your pull request
GitGuardian id GitGuardian status Secret Commit Filename
8730391 Triggered Generic Private Key 872ff64aca2357e294aca4a2141493e714e3ce63 benchmark/deepflow/go-server/key.pem View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secret safely. Learn here the best practices.
  3. Revoke and rotate this secret.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

gitguardian[bot] avatar May 25 '25 00:05 gitguardian[bot]