Eunjae Lee

Results 63 comments of Eunjae Lee

Yeah it's related, but if there is only one commit, that will happen because there is no commit to release *since* the commit you chose. Unfortunately the behavior we have...

> having a .env in the root of a package that you will publish is too risky I agree. Even though `.env` is excluded by `.gitignore` and `.npmignore`, unfortunately there...

> Umm. > If you don't think about generating the `.env` file, how do you think adding some messages when running `shipjs setup`, and `shipjs prepare`? We have this step...

Hi @vinayakkulkarni Do you think [`publishCommand`](https://github.com/algolia/shipjs/blob/634e065314665caf075f8f011a9a56348c1ff0eb/packages/shipjs-lib/src/lib/config/defaultConfig.js#L109:L109) works for you? ```js ({ isYarn, tag, defaultCommand, dir }) => defaultCommand ``` It may not have all the necessary information for you, but...

User could provide a config like the following to allow many use-cases. ```js // ship.config.js const coreTeam = ['username1', 'username2', ...]; export default { commentAfterRelease: ({ id, // issue or...

~probably related to https://github.com/algolia/instantsearch.js/issues/4225~ No, it's not.

Hi there, thanks for reaching out to us. Could you give us a reproducible example? It will be very helpful for us to tackle this issue. You can use this...

@ed42311 while your workaround seems good to me, I'm curious why you added `:key` to ``?

@ed42311 hmm I'm not sure. It's more like a way to invalidate and rerender component when `$route.fullPath` changes rather than an optimization, which I'm not so sure why they put...

You can control the internal [cache](https://www.algolia.com/doc/api-reference/widgets/infinite-hits/react/#widget-param-cache) of InfiniteHits now. ```jsx import isEqual from 'react-fast-compare'; function getStateWithoutPage(state) { const { page, ...rest } = state || {}; return rest; } function...