Fake_APIs icon indicating copy to clipboard operation
Fake_APIs copied to clipboard

Adding more data as REST-API in JSON format πŸ‘¨β€πŸ’»βœ¨πŸŽ«

Open euhidaman opened this issue 3 years ago β€’ 10 comments

Add a new REST-API JSON file, and create a pull request.

Also, make sure to Star this repository. So that, It can reach to a wider audience, and more people can contribute to it !!

euhidaman avatar Oct 05 '21 06:10 euhidaman

Hey, I am new to open source and as this is a good first issue. I would like to work on it, but just a small doubt, can u explain what exactly we have to do or suggest me some references for it?

legion20 avatar Oct 05 '21 06:10 legion20

So, in simple terms, you must work and contribute in the following steps :

  1. Fork the repo and clone it on your local machine.
  2. Create a branch, where you must do your own contributions.
  3. Create a new JSON file with your custom name, and with your chosen data. The file, should be like this : sharksinfo.json
  4. Then stage and commit your changes.
  5. Finally, create a pull request, so that I can merge it with this project repository.

Note : To know, how to Fork, Clone, Create a branch and Creating a pull request, you can view this 5 minute video : https://www.youtube.com/watch?v=rgbCcBNZcdQ

euhidaman avatar Oct 05 '21 07:10 euhidaman

Ok. Got it. So, basically I have to create a JSON file with my preferred dataset. If I am right, can u assign me this issue?

legion20 avatar Oct 05 '21 07:10 legion20

No need of assigning. Interested people can directly create a pull request.

euhidaman avatar Oct 05 '21 07:10 euhidaman

Hi @euhidaman, I have raised a pull request to add top 5 basket ball players #6. Please review.

mephi007 avatar Oct 06 '21 16:10 mephi007

hi @euhidaman, I have raised a pull request to add countries data #11. Please review. πŸš€

rehanpunjwani avatar Oct 10 '21 09:10 rehanpunjwani

Hi, @euhidaman please review #12 and let me know if any changes are required.

sonalsingh25 avatar Oct 10 '21 10:10 sonalsingh25

@euhidaman Can you please check if #14 looks good to you?

rahulxsingh avatar Oct 11 '21 09:10 rahulxsingh

Hi @euhidaman, I have raised Pr #27 to add basket Ball teams. Please review and merge

mephi007 avatar Oct 19 '21 06:10 mephi007

Hello @euhidaman , I have raised PR as following: Create Indian-Sweets.json #31 Please review and accept.

Rosy03 avatar Oct 24 '21 00:10 Rosy03