tutorials icon indicating copy to clipboard operation
tutorials copied to clipboard

aws-modules/aws-reactive/ - FluxResponseProvider potentially Unnecessary

Open ericghara opened this issue 3 years ago • 3 comments
trafficstars

There is a canned AsyncResponseTransformer that I believe implements the same functionality as FluxResponseProvider. Removing the custom implementation of AsyncResponseTransformer would make the tutorial and examples more concise.

for example:

Flux<ByteBuffer> responseBody = Mono.fromFuture(s3Client.getObject( request, AsyncResponseTransformer.toPublisher() ).flatMapMany( Flux::from );

ericghara avatar Aug 23 '22 01:08 ericghara

Hey, @ericghara.

Can you provide the link to the article, so we can take a look?

ulisseslima avatar Aug 23 '22 01:08 ulisseslima

Sure @ulisseslima. It's java-aws-s3-reactive. Here's the javadoc of the method I'm describing. If it's helpful I can submit a PR.

ericghara avatar Aug 23 '22 06:08 ericghara

Thanks, @ericghara, we're already looking into the issue.

ulisseslima avatar Aug 29 '22 14:08 ulisseslima

The code and article have been updated to use the AsyncResponseTransformer and remove the custom class.

lor6 avatar Oct 11 '22 14:10 lor6