ebay-purchase-report icon indicating copy to clipboard operation
ebay-purchase-report copied to clipboard

Date not showing

Open molove opened this issue 5 years ago • 10 comments

The transaction date isn't showning in the quick report. I get the same result in both Brave Version 0.70.121 Chromium: 78.0.3904.70 (Official Build) (64-bit) and Firefox 70.0 (64-bit)

molove avatar Oct 27 '19 14:10 molove

Same issue here :(

tmilar avatar Nov 13 '19 02:11 tmilar

Found the issue - problem is that ebay UI changed the date value class name from "row-date" to "row-value".

I have just submitted PR #15 that fixes this isse @molove @eugenmihailescu

tmilar avatar Nov 13 '19 03:11 tmilar

hi, how do I get this fix, please? many thanks

ississi avatar Nov 15 '19 06:11 ississi

any update on this? thanks :)

mjflower avatar Dec 03 '19 13:12 mjflower

Just tried the script, encountered the same problem, investigated the cause and made the same fix as @tmilar ... should've remembered to check the Issues queue first! D'oh!

alastaira avatar Jan 04 '20 06:01 alastaira

So, how do I get a fixed version of the add-in please, or how do I fix it myself? (I'm a Windows user) Many thanks

ississi avatar Jan 06 '20 09:01 ississi

To fix the issue, you need to download the source and make a simple edit on line 138 of script.js from var purchaseDate = getInnerText(orders[order].querySelector('.order-row .purchase-header .row-date'), ''); to var purchaseDate = getInnerText(orders[order].querySelector('.order-row .purchase-header .row-value'), '');

The annoying thing is that you then need to recompile and sign the code again before you're able to import it back into Firefox. Hopefully @eugenmihailescu will accept PR #15 that fixes this issue so you won't need to do that yourself though.

alastaira avatar Jan 06 '20 10:01 alastaira

Thanks alastaira, here's hoping the PR gets accepted :-D

ississi avatar Jan 06 '20 13:01 ississi

To fix locally, since author isn't updating the extension.

  1. Download the extension folder (I used VS git sync, but you can also git pull https://github.com/eugenmihailescu/ebay-purchase-report)
  2. Change the line @alastaira mentioned
  3. Go to Chrome/More Tools/Extensions
  4. Set Developer mode to ON
  5. Load unpacked and point to folder with modified extension source
  6. You'll also need to remove developer element from the manifest to make it work (looks like Chrome extension manifest no longer allows it).

Don't forget to unload the 1.0.24. I changed version in the local modified one to 1.0.24.1 to distinguish from published one.

On reload the Purchase Date appeared in the generated report. Good luck :)

micwebnet avatar Feb 18 '20 04:02 micwebnet

Firefox instructions, for those who don't want to install node.js to run Mozilla's web-ext tool and don't want to deal with signing:

  1. Make sure you are running a version of Firefox that allows unsigned extensions. I use Nightly, which is one such version. Go to about:config and set xpinstall.signatures.required to false. This will not work if you do not have a version of Firefox that allows unsigned extensions!
  2. Either clone this one and apply the fix, or clone @tmilar's repo
  3. Edit src/extension/manifest.json to add
	"browser_specific_settings": {
		"gecko": {
			"id": "[email protected]"
		}
	}

substituting yourdomain.com appropriately. 4) Go to src/extension and zip the contents into a file ebay-purchase-report.xpi. Make sure the zipping only uses either "store" or "deflate" compression mechanisms! 5) Go to about:config and Install Add-On From File.

andlabs avatar May 08 '20 17:05 andlabs