gifencoder icon indicating copy to clipboard operation
gifencoder copied to clipboard

Add comment in example about quality

Open potmo opened this issue 4 years ago • 5 comments

I opted to just add a small comment in the example so that those that search can find it.

potmo avatar Jan 26 '21 10:01 potmo

no reason this shouldn't be accepted, so dumb that this isn't explained anywhere, unless you dig through the source:

/* Sets quality of color quantization (conversion of images to the maximum 256 colors allowed by the GIF specification). Lower values (minimum = 1) produce better colors, but slow processing significantly. 10 is the default, and produces good color mapping at reasonable speeds. Values greater than 20 do not yield significant improvements in speed. */

although it's still not exactly clear how it's applying this quality. a value of 1 still seems to produce a few inaccurate colors sometimes.

skeddles avatar Sep 06 '21 19:09 skeddles

This should be accepted.

JoshuaPerk avatar Dec 12 '21 13:12 JoshuaPerk

Its soon a year since I made this patch. What's taking so long?

potmo avatar Dec 12 '21 14:12 potmo

@eugeneware

skeddles avatar Dec 13 '21 15:12 skeddles

2 years. Should i close it?

potmo avatar Jul 07 '23 13:07 potmo