Eugene Manuilov
Eugene Manuilov
> In `includes/Core/Util/BC_Functions.php`: > * Add a new protected static method named `is_ssl`. This method should basically be an improved version of the core `is_ssl()` function so that it supports...
@nfmohit, yes, there might be some cases when the `is_ssl` function may return incorrect results... however I am not sure that we have to add a vendor specific checks to...
> * Clicking on the button should expand the module settings in edit mode. @techanvil, modules like AdSense and TwG show different setup flows based on some parameters, which will...
> I have updated the AC to specify navigating to the setup page, Thanks, @techanvil, but after reviewing IB for #5621 it turns out that things are more complicated than...
@aaemnnosttv I think in this case it's necessary if we want to keep our settings API consistent. We had an edge case for AdSense and we added the ability to...
@aaemnnosttv ok, i am fine with this if we update ACs for #5621. Do we need to update design mocks in Figma as well? Darren will compare the behaviour in...
> * In `assets/js/components/Button.js`, add the following code: > > * Add a new boolean prop called `secondary` to the `Button` component. > * Add a new className `mdc-button--secondary` and...
Thanks, @hussain-t. IB ✔️