Eugene Manuilov

Results 169 comments of Eugene Manuilov

Hi @AlexanderSchoenfeld, I don't work with Typescript and don't know it. So if you want it, feel free to submit a pull request.

Hey @hankewins, have you seen cli command in the [README section](https://github.com/eugene-manuilov/react-gettext#poedit) for POEdit? Did it help or you still have troubles?

Thanks, @dcholth! It is pretty simple, just change translations catalog and plural form for your HOC and it should trigger re-render cycle. See example application: https://github.com/eugene-manuilov/react-gettext/tree/master/examples/poedit Hope it will help.

Hi @pereirinha! I have submitted a fix for this issue. Can you try it on your end to make sure it works properly? There is **fix/multiple-editors** branch where you can...

Thanks, @benbowler. Mostly looks good to me. > * Create the primary CTA "Set up Ads" as a default `Button` component which links to `${ settingsURL }&slug=ads&reAuth=true` with the `settingsURL`...

Thanks, @benbowler. IB ✔️

Thanks, @zutigrm. IB technically looks good to me, but I think we need to add one more thing to it. We need to make sure that when Ads or Analytics...

> * Before or after `saveSettings` is called, invoke `saveConversionTrackingSettings` action on `CORE_SITE` store to save conversion tracking setting @zutigrm this should happen after settings have been successfully saved and...

Thanks, almost looks good. The last thing let's rename `canSubmitConversionTrackingSettings` to `hasConversionTrackingSettingChanged` since that is the more relevant name for that selector.

Thanks, IB :heavy_check_mark: