cfpack icon indicating copy to clipboard operation
cfpack copied to clipboard

Support ignore empty changesets when deploying

Open dytarlatam opened this issue 5 years ago • 2 comments

When deploying the stack in CI/CD process, it would be helpful to not fail when there is nothing to do. AWS CLI has an argument --no-fail-on-empty-changeset to do that. I couldn't find any other UpdateStack argument to mimic that behaviour.

I guess that it have to be handled on the callback.

Thanks! PS: great work!

dytarlatam avatar Jun 18 '20 21:06 dytarlatam

Hi @dytarlatam

i have just published a new version - 1.4.0. It exits with 0 exit code if there is a validation error during updating the stack. It should solve the CI/CD failing issue. Could you please check it on your end and let me know if it helps or not?

eugene-manuilov avatar Jun 19 '20 06:06 eugene-manuilov

Thanks @eugene-manuilov! (I'm the same user as before but realized that was signed-in with a client's account :P )

Regarding validation errors, I'm not sure they have to be always ignored even in CI/CD. The request was just about the case there is an empty changeset. If there are any other validation errors I think that non-zero exit code is correct.

I would like to update cloudformation stack during CI build, and most of the time there are no stack changes. However, if there are any other validataion errors failing the build might be right thing to do. I'm not sure what other validation errors exist aside of the empty changeset.

ignacioalles avatar Jun 19 '20 21:06 ignacioalles