Merge CMS modifications to official EUDAQ repository
Merged with official EUDAQ repo to incorporate the latest updates
From the "CMS side" we made a new module called CMSIT to handle CMS phase-2 readout chip
I need to look carefully through it and compare with https://github.com/eudaq/eudaq/pull/743 That is my pending merge request which contains among other things the MMC3/STCONTROL converter (which you were probably using but did not include), the necessary online monitor changes, online monitor changes for RD53A/B (single chip only) and xy correlation. At the first glance it seems that at some point you copied my changes so it might be compatible but will take time. Also I don't know whether your stuff also contains what Brainislav Ristic had pending for CMS (and general).
Hi @arummler , sure I understand it might take some time: https://github.com/eudaq/eudaq/pull/756#issuecomment-2285973337
No problem
Many thanks
Hi, I need to add that I didn't implement all these changes myself
Another colleague, that now left the project, made several changes to the code
I'm personally responsible for the CMSIT module
Please let me know if there are other changes you want me to implement
Hi, I was wondering what was the status of this merge request.
Many thanks.
- Mauro.
Sorry, still wanted to compare the online monitor stuff to what I have in #743 as we are sharing both MMC3 read out FEI4 timing plane as well as the RD53 modules (to some extent). Trying...
Also would really like to merge my CI update before major merges.
Dear Manager, I was wondering what was the status of the merging.
Cheers,
- Mauro.
I am fine with all the changes and if @arummler is not objecting, we can merge this from my side.
I still wanted to cross check my online monitor changes #743 for compatibility (we are using the same chip but different daq/independent development). Will try asap.
And I would prefer to have my CI MR #738 merged first to test on all OS.
Dear Manager, I was wondering what was the status of the merging.
Cheers,
- Mauro.
Dear Manager, I was wondering what was the status of this Pull Request.
Cheers,
- Mauro.
Dear Mauro, I am unfortunately in the middle of the YETS and hence I did not have any time to continue. My only issues were: a) the online monitor extension for RD53b (as we are using the same chip in ATLAS and CMS but different producers and different module definitions) and b) your inclusion of ROOT which in principle is fine but redundant as we are already doing it centrally and using the old way of linking (should be done target based nowadays). As you now waiting already for months I will merge it, but if I run into conflicts in a) as soon as I get my MR approved we will need to discuss.