vim-markdown-composer icon indicating copy to clipboard operation
vim-markdown-composer copied to clipboard

Use upstream GitHub styles

Open euclio opened this issue 7 years ago • 3 comments

According to https://github.com/euclio/vim-markdown-composer/issues/51#issuecomment-361087675 my patch is no longer needed.

euclio avatar Jan 28 '18 22:01 euclio

And if you do find an example which shows that patch is still needed, please share - perhaps it is something that can be fixed in one of the upstreams 🙂 As I said, my primary concern with having the patch is that it doesn't highlight inline code blocks as highlight.js doesn't handle these.

max-baz avatar Jan 28 '18 23:01 max-baz

Oh no, I was wrong, it still conflicts with highlight.js 😞

Now that you added g:markdown_composer_custom_css it's much simpler to test different themes against the original github-markdown-css.

I'll see if there is some way to adapt the patch to fix inline code blocks or whether it makes sense to fix one of the upstreams, I'll get back to you.

max-baz avatar Jan 28 '18 23:01 max-baz

It appears github-markdown-css is an autogenerated code, so no patches for highlight.js will be merged, and highlight.js will most certainly not merge any hacks specifically for "markdown-body" class... So it looks you've already taken the best approach available.

To fix styling of inline code blocks, I'll add this to my custom css - feel free to add it to your patch too.

.markdown-body :not(pre) > code {
  background-color: rgba(27, 31, 35, 0.05);
}

max-baz avatar Jan 28 '18 23:01 max-baz