eudi-doc-architecture-and-reference-framework
eudi-doc-architecture-and-reference-framework copied to clipboard
eu-digital-identity-wallet
Minor ortography fixes
Minor ortography fixes for the ARF and the annexes. Fixes are split into multiple commits and each commit has an explanatory comment.
One of the changes is in docs/media/image7.svg (replaced ‘EUDI Wallet instance’ with ‘EUDI Wallet Instance’). It looks like the related file docs/media/image7.png already has the latter ortography and thus no changes for that file is needed.
I pushed some additional orthography fixes. Should I create a new pull request or keep the commits in this one?
One of the added fixes is in docs/media/image1.svg (capitalised solution in ‘Wallet Solution’). This fix should be done in the related file docs/media/image1.png, too.
Process wise the review already started so new commits will make it more difficult. On top of this the PR has already approved by two reviewers before the new commits.
However I checked the commits one by one and my positive vote remains unchanged ;-)
Okay, thank you for your patience. I am sorry that I deviated from the process. I should have asked first before pushing new commits.
Thank you for submitting the Pull Request.
We have reviewed ARF 1.4, and all the minor ortography issues have been fixed (or will be fixed in ARF 1.4.1)
@digeorgi
I have prepared a new PR that introduces all the related changes but rebased so they can be applied over v1.4.0. Since there has been no activity from the initial author, I suggest we proceed with the merge as follows:
- https://github.com/eu-digital-identity-wallet/eudi-doc-architecture-and-reference-framework/pull/293
@skounis, thanks for making a new PR! I was on summer vacation when you asked to rebase the branch.