meteor-accounts-ldap icon indicating copy to clipboard operation
meteor-accounts-ldap copied to clipboard

get thee a linter

Open jedwards1211 opened this issue 9 years ago • 2 comments

When I copied your source into my project, I got the following eslint errors:

/Users/andy/frcs-portal/jcore-react-components/meteor/ldap/LDAPAccountSupport.js
  200:33  error    'retObj' is not defined                   no-undef
  240:7   warning  'userOptions' is defined but never used   no-unused-vars
  260:9   warning  'stampedToken' is defined but never used  no-unused-vars
  279:14  error    'ldapObj' is not defined                  no-undef
  288:41  error    'ldapObj' is not defined                  no-undef
  291:9   error    'ldapObj' is not defined                  no-undef
  310:7   warning  Unexpected console statement              no-console

4 bugs waiting to happen that could have been easily prevented by using eslint.

jedwards1211 avatar Jun 26 '16 19:06 jedwards1211

@jedwards1211 willing to merge in a PR with a linter if you submit. I don't use this in any of my projects anymore, so all I have time to do is maintain and support where I can.

etyp avatar Dec 08 '16 03:12 etyp

@etyp Heh, unfortunately I didn't end up using this either.

jedwards1211 avatar Dec 08 '16 17:12 jedwards1211