ettoolong
dysfunction with dark reader
@phantomfermion Sorry, I guess this is a little bit difficult.
Maximize Video fix web page style to keep the video always maximal. I guess Dark Reader do something similar to keep web page in dark color.
That's why Dark Reader and Maximize Video can't work together, they change web page style each other and trigger change event, then they loop events Infinitely. I have no idea about how to fix it in this moment. 🙁
Anyway, thanks for your feedback.
I have no idea about how to fix it in this moment
You could point out to the code responsible for inserting/updating the stylesheets. I'm from the Dark reader team and we are the one causing the lag only I can't point my finger on thr exact behavior why as we have a fail safe of max of 10 modifying style within 10 seconds.
@Gusted, Thank you, 😀
Here is how my extension(hereinafter called the "MV") working: After user selected a video element, MV cache the style of the video node then combined the cache and vnStyle in new style.
Then MV will try to LOCK the video node style(due to some websites changing the style attribute again), I think here is the problem, when other content script try to change the style attribute of video node, MV will reset the style again.
Do you have any ideas about how to prevent conflict between MV and Dark reader? e.g. modify the style-checking in MV and ignore color style changing?
I will have a look soon, but I think we need to edit our existing code to prevent this.
A fix should be made trough #31 or something similair. But it's definitely the error. Not sure how Darkreader was the one targetted by slow code....
A fix should be made trough #31 or something similair. But it's definitely the error. Not sure how Darkreader was the one targetted by slow code....
Solved the problem after remove the background style. (code) MV set background color of video element to black because some websites do not set the background color of the video element, and a white border will be left on the edge after active MV.
Is there a way to keep the video background black? Whether Dark Reader is installed or not.
Thanks for your helping :)
You just gave dark reader no reason to monitor your style :) That's how you solved it.
Is there a way to keep the video background black? Whether Dark Reader is installed or not.
I don't think so.