etsy
GRAPHITE_HOST_PORT
It would be handy to have a GRAPHITE_HOST_PORT setting so that if graphite runs on a different port to the standard port 80, links within the skyline frontend can be created appropriately. Just appending the port breaks analyzer.py:
GRAPHITE_HOST = 'http://graphite.example.com:81'
analyzer.py's nc post to graphite does not work with a port declared as it is only stripping the 'http://' and not the port, this means you can have both valid links and skyline posting to carbon (it seems).
We would need to pass the port to nc as an option, right?
Pardon the brevity
On Oct 16, 2013, at 3:24 AM, earthgecko [email protected] wrote:
It would be handy to have a GRAPHITE_HOST_PORT setting so that if graphite runs on a different port to the standard port 80, links within the skyline frontend can be created appropriately. Just appending the port breaks analyzer.py:
GRAPHITE_HOST = 'http://graphite.example.com:81'
analyzer.py's nc post to graphite does not work with a port declared as it is only stripping the 'http://' and not the port, this means you can have both valid links and skyline posting to carbon (it seems).
— Reply to this email directly or view it on GitHub.
related to #34 which would solve the nc part by adding the GRAPHITE_PORT config option, but we'd maybe need to change it to two seperate config options since both the webapp and carbon could be listening on non-standard ports.
Just started patterning in puppet today and I have not got a full overview, so apologies if this seems clever or cynical, just trying to understand and see how things map and super excited.
I briefly looked through some code and I think the port in this case would just be added to the construction of the URL string if GRAPHITE_PORT is set in:
src/webapp/static/js/skyline.js
var src = GRAPHITE_HOST + GRAPHITE_PORT + '/render/?width=1400&from=-1hour&target=' + name;
And the analyser nc would not need to change in that case, but I also think there an assumption that GRAPHITE_HOST is the same as the CARBON_HOST? And as @draco2003 pointed out there may be a CARBON_PORT required as well.
Maybe? :)
WOW!!! This is awesome stuff etsy is pushing. I have been excited since hearing reading loupe. Super happy we are patterning kale now \o/
Seen our first skyline anomalies :+1:
<3
Oh, I see. If we were to just strip the port at the end of the Graphite string when we ping for meta-metrics, this should solve your problem right?
Also solved here in my commit: https://github.com/etsy/skyline/pull/72
On Wed, Apr 2, 2014 at 1:55 PM, William Cummings [email protected]:
@astanway https://github.com/astanway this is what I have done in #81https://github.com/etsy/skyline/pull/81
Reply to this email directly or view it on GitHubhttps://github.com/etsy/skyline/issues/58#issuecomment-39361942 .