Sahale icon indicating copy to clipboard operation
Sahale copied to clipboard

Fix NullReferenceException if one provides fake url as a server

Open trams opened this issue 8 years ago • 4 comments

trams avatar Feb 06 '17 10:02 trams

Not a bad idea here. iirc at Etsy it was handy to fail fast if someone deployed with a bad server URL we might not want to mask that completely, but could handle it better than NPE. Any thoughts about doing something in between? Any Etsy folks have input on this?

initialcontext avatar Feb 06 '17 16:02 initialcontext

I am okay with either solution. We could throw a distinct exception instead of NPE

trams avatar Feb 07 '17 19:02 trams

My instinct is a better error message would be the play here, but I'll defer to the Etsy folks to decide that as they can merge. Nice find, thanks for the contrib!

initialcontext avatar Feb 07 '17 20:02 initialcontext

@trams Thanks for your contribution! We'd love to add a distinct exception/informative error message, as @initialcontext suggested.

nixsticks avatar Jul 07 '17 13:07 nixsticks