python-dependency-injector
python-dependency-injector copied to clipboard
ets-labs
Add Python 3.12 Support (#752)
-
Ignore .vscode
-
Python 3.12 Support
-
Change base python to 3.12 and pin pydantic to V1
-
all tests passed
-
ci: change default python to 3.12
-
remove legacy python versions
-
annotate pydantic models for tests
@rmk135 please, can you give us (community) some expectations about this pr?
@rmk135 can you please look into this PR when you have the chance? This package is at least used by 2.5k repositories (based on GitHub stats) and Python 3.12 has been released 2 months ago. All the projects that are using this package are being blocked from updating to Python 3.12.
If you no longer have the capacity to maintain this project, would you be able to look for collaborators or transfer ownership to someone who can maintain it? @anton-petrov who is the maintainer of pyenv has offered to help maintain this project https://github.com/ets-labs/python-dependency-injector/issues/688#issuecomment-1764296938 Maybe you can work out something with them for the future of this project?
@boonya @ustims, you guys seem to be working for ets-labs. Can you contact @rmk135?
As a temporary solution, anyone can install directly from the repository https://github.com/anton-petrov/python-dependency-injector or create their own fork.
@anton-petrov I would be very grateful if you could publish compiled wheels to PyPI.
@anton-petrov I would be very grateful if you could publish compiled wheels to PyPI.
Yeah plz do it if possible. Will help me a lot
@rmk135 please give a reply. I need to upgrade our project to python 3.12 . it is now mandatory for us but due to this package can not upgrade . and it will be difficult for us to use others alternative packages cause in that case need to change lot of things . Please give some update . Thanks
@rmk135 has no Github activity over the last two months. They are probably not just ignoring the requests here but are unable to check Github for whatever reasons.
@StummeJ as a previous contributor of this repo, are you able to help merging this PR? Or advice on who might be able to help? (sorry for the random ping.. just chose the last person to contribute to this repo that is not @rmk135)
As mentioned in the issues referenced here: https://github.com/ets-labs/python-dependency-injector/issues/763#issuecomment-1817466095
it seems @rmk135 does not have a lot of time available to implement new features on the repo. He even mentioned that he's looking for an additional/new maintainer link. @anton-petrov offered his help, but not sure if that went any further than the offer.
Unfortunately, this is the main problem - he himself has already stopped working on the library, but also he has not handed it over to anyone for further maintenance. So the project hangs in the air.
If any of you have LinkedIn Premium than you can go ahead and ping @rmk135 there. Here is a link to his profile. All I could do was to left a comment.
I've actually switched to using Neoteroi's Rodi (along with their configuration manager). They'er actively building a web framework for python so it's still maintained (be it a bit slow (days) sometimes)
Rodi and essentials-configuration was inspired by dotnet's dependency injection and config manager.
First, python 3.12 support was initiated by @rmk135 and then he disappeared. Then @anton-petrov started developing of his fork and disappeared too. Well, now it's my time to take that risk.
I took Anton's PR and made some improvements to the point where it become possible to build and publish to PyPI. I didn't bother figuring out how to build packages for old interpreters and dropped this code. I'm not sure I have time to maintain the library either, so I can't promise I'll be merging any other PRs, but I can try.
pip install dependency-injector-fork
UPD: ~~arm64 wheels not built yet, in progress~~ UPD2: arm64 wheels are ready
this is sad :/ I guess this is end for this library in production environments.
Hello, I wrote small DI framework as a replacement for dependency-injector with minimal changes https://github.com/modern-python/that-depends
No wiring and Python 3.12 is supported.
coverage: 0.0% (-92.0%) from 92.016% when pulling 7770ffe48b6b95b308993adcb390af31786f173a on feature/python-3.12 into cc2304e46e054ae08dc12995428759fbfb51af10 on develop.
coverage: 0.0% (-92.0%) from 92.016% when pulling 7770ffe48b6b95b308993adcb390af31786f173a on feature/python-3.12 into cc2304e46e054ae08dc12995428759fbfb51af10 on develop.
coverage: 0.0% (-92.0%) from 92.016% when pulling 7770ffe48b6b95b308993adcb390af31786f173a on feature/python-3.12 into cc2304e46e054ae08dc12995428759fbfb51af10 on develop.
coverage: 0.0% (-92.0%) from 92.016% when pulling 60ccf49ac710ce9d9dcb12442f1ad5a54b76bac2 on feature/python-3.12 into cc2304e46e054ae08dc12995428759fbfb51af10 on develop.
coverage: 0.0% (-92.0%) from 92.016% when pulling 58db04ac0d4c0587dc0e02119232dded97d62532 on feature/python-3.12 into cc2304e46e054ae08dc12995428759fbfb51af10 on develop.
coverage: 0.0% (-92.0%) from 92.016% when pulling 58db04ac0d4c0587dc0e02119232dded97d62532 on feature/python-3.12 into cc2304e46e054ae08dc12995428759fbfb51af10 on develop.
coverage: 0.0% (-92.0%) from 92.016% when pulling 5f56dc830ad0fbcdf4d7d96ab6e450736292f95a on feature/python-3.12 into cc2304e46e054ae08dc12995428759fbfb51af10 on develop.
Does anyone have any idea why coveralls is showing 0% coverage? @macieyng @zeshuaro @MahmudulHassan5809 @anton-petrov
@camcima Because the version of Cython in this PR can't compile the C code with the needed instructions for calculating coverage. The newest version of Cython runs into a segmentation fault error on every other test. There is not good solution to fix coverage now.