python-dependency-injector icon indicating copy to clipboard operation
python-dependency-injector copied to clipboard

Add Python 3.12 Support (#752)

Open rmk135 opened this issue 7 months ago • 34 comments

  • Ignore .vscode

  • Python 3.12 Support

  • Change base python to 3.12 and pin pydantic to V1

  • all tests passed

  • ci: change default python to 3.12

  • remove legacy python versions

  • annotate pydantic models for tests

rmk135 avatar Nov 15 '23 01:11 rmk135

👋 Can you estimate when this PR will be finished?

macieyng avatar Nov 24 '23 08:11 macieyng

@rmk135 please, can you give us (community) some expectations about this pr?

anton-petrov avatar Nov 28 '23 05:11 anton-petrov

Maybe temporarily merge PR despite of some failed unit tests...

anton-petrov avatar Dec 01 '23 05:12 anton-petrov

@rmk135 can you please look into this PR when you have the chance? This package is at least used by 2.5k repositories (based on GitHub stats) and Python 3.12 has been released 2 months ago. All the projects that are using this package are being blocked from updating to Python 3.12.

If you no longer have the capacity to maintain this project, would you be able to look for collaborators or transfer ownership to someone who can maintain it? @anton-petrov who is the maintainer of pyenv has offered to help maintain this project https://github.com/ets-labs/python-dependency-injector/issues/688#issuecomment-1764296938 Maybe you can work out something with them for the future of this project?

zeshuaro avatar Dec 03 '23 00:12 zeshuaro

@boonya @ustims, you guys seem to be working for ets-labs. Can you contact @rmk135?

macieyng avatar Dec 05 '23 22:12 macieyng

As a temporary solution, anyone can install directly from the repository https://github.com/anton-petrov/python-dependency-injector or create their own fork.

anton-petrov avatar Dec 06 '23 03:12 anton-petrov

hello @rmk135 , is there any update about this PR.

MahmudulHassan5809 avatar Dec 11 '23 14:12 MahmudulHassan5809

@anton-petrov I would be very grateful if you could publish compiled wheels to PyPI.

Pentusha avatar Jan 15 '24 12:01 Pentusha

@anton-petrov I would be very grateful if you could publish compiled wheels to PyPI.

Yeah plz do it if possible. Will help me a lot

MahmudulHassan5809 avatar Jan 15 '24 19:01 MahmudulHassan5809

@rmk135 any update on this PR?

JacobGeoGeek avatar Jan 18 '24 01:01 JacobGeoGeek

@rmk135 you're alive?

alexted avatar Jan 27 '24 18:01 alexted

@rmk135 please give a reply. I need to upgrade our project to python 3.12 . it is now mandatory for us but due to this package can not upgrade . and it will be difficult for us to use others alternative packages cause in that case need to change lot of things . Please give some update . Thanks

MahmudulHassan5809 avatar Jan 28 '24 07:01 MahmudulHassan5809

@rmk135 has no Github activity over the last two months. They are probably not just ignoring the requests here but are unable to check Github for whatever reasons.

@StummeJ as a previous contributor of this repo, are you able to help merging this PR? Or advice on who might be able to help? (sorry for the random ping.. just chose the last person to contribute to this repo that is not @rmk135)

s-maheshbabu avatar Jan 28 '24 21:01 s-maheshbabu

As mentioned in the issues referenced here: https://github.com/ets-labs/python-dependency-injector/issues/763#issuecomment-1817466095

it seems @rmk135 does not have a lot of time available to implement new features on the repo. He even mentioned that he's looking for an additional/new maintainer link. @anton-petrov offered his help, but not sure if that went any further than the offer.

benvdh-incentro avatar Jan 28 '24 23:01 benvdh-incentro

Unfortunately, this is the main problem - he himself has already stopped working on the library, but also he has not handed it over to anyone for further maintenance. So the project hangs in the air.

alexted avatar Jan 29 '24 08:01 alexted

If any of you have LinkedIn Premium than you can go ahead and ping @rmk135 there. Here is a link to his profile. All I could do was to left a comment.

macieyng avatar Jan 29 '24 09:01 macieyng

I've actually switched to using Neoteroi's Rodi (along with their configuration manager). They'er actively building a web framework for python so it's still maintained (be it a bit slow (days) sometimes)

Rodi and essentials-configuration was inspired by dotnet's dependency injection and config manager.

StummeJ avatar Jan 29 '24 16:01 StummeJ

First, python 3.12 support was initiated by @rmk135 and then he disappeared. Then @anton-petrov started developing of his fork and disappeared too. Well, now it's my time to take that risk.

I took Anton's PR and made some improvements to the point where it become possible to build and publish to PyPI. I didn't bother figuring out how to build packages for old interpreters and dropped this code. I'm not sure I have time to maintain the library either, so I can't promise I'll be merging any other PRs, but I can try.

pip install dependency-injector-fork

UPD: ~~arm64 wheels not built yet, in progress~~ UPD2: arm64 wheels are ready

Pentusha avatar Jan 29 '24 16:01 Pentusha

this is sad :/ I guess this is end for this library in production environments.

gokturkDev avatar Apr 24 '24 12:04 gokturkDev

Oh, is it really no more update...? 😢

PunRabbit avatar May 23 '24 05:05 PunRabbit