Bob Ippolito

Results 485 comments of Bob Ippolito

So far I have not seen any evidence that any update events happen on unmount. I tried to reproduce it by taking the example app and providing a button to...

Please re-open or create a new issue when you have a full example that reproduces this issue.

I haven't fixed the problem but here are the relevant changes to the theme so you can see the selection properly https://stackblitz.com/edit/facebook-lexical-akmwfitx?file=src%2Fstyles.css,src%2FExampleTheme.ts,index.html,src%2Fmain.tsx

You'll need to sign the CLA before we can run the tests and possibly merge this PR

It doesn't look like this change passes the existing e2e test suite (possibly because the tests should change to accommodate this new behavior), and there are no new tests that...

Doesn’t look unrelated? This is the failing test [chromium] › packages/lexical-playground/__tests__/e2e/CopyAndPaste/html/TablesHTMLCopyAndPaste.spec.mjs:351:3 › HTML Tables CopyAndPaste › Copy + paste - Merge Grids

I probably won’t have time to look into this for a few days, this level of question is basically asking me to fix it. It’s a long holiday weekend in...

The reason why the DOM for those cells is being recreated is because `updateDOM` is returning true due to the background color change. TableCellNode doesn't implement the optimization where the...

Closing as stale, please re-open when/if you intend to complete it.

Yes “flat” moves a property out of the $ key to the root of the node’s JSON, allowing for backwards/forwards compatibility of the serialization