Bob Ippolito comments

Results 186 comments of


                                            Bob Ippolito

trafficstars

Converting dictionaries with the same integer and string keys produce multiple keys in the json

I expect that this error checking feature would be expensive to implement (both in runtime cost and lines of code). I think the most sensible thing to do would be...

Converting dictionaries with the same integer and string keys produce multiple keys in the json

The fact that this potential issue has been possible since the beginning, and nobody else has been bothered by it, is very relevant. Not following a "SHOULD" doesn't make it...

Converting dictionaries with the same integer and string keys produce multiple keys in the json

Arguably the best solution to this problem would be to have an option that allows you to turn off the automatic coercion to string as object keys. This way you'd...

`ensure_ascii=False` could do with a C implementation

It shouldn't be more complicated, it just didn't get implemented because we weren't using that code path. If you'd like to try your hand at a PR I'd be happy...

Current JSON outputs for Infinity, -Infinity, and NaN are not valid JSON. New option to allow output them as String.

It's unlikely to get merged, just because simplejson already has too many options, and this has never been requested before. I do otherwise think it is a nice approach to...

Current JSON outputs for Infinity, -Infinity, and NaN are not valid JSON. New option to allow output them as String.

If you're going to do that, I would probably recommend that the default be to throw an exception (`allow_nan=False`) or encode those values with null like JavaScript does. ```javascript >...

Current JSON outputs for Infinity, -Infinity, and NaN are not valid JSON. New option to allow output them as String.

Sure, I'm just recommending a default that rejects them or does what JavaScript does.

Any plans to simplify customising `float` representation?

No, this is not planned. Why would you want to do this?

Any plans to simplify customising `float` representation?

That's a very unfortunate scenario, hashing a json encoded string is just asking for trouble. floats are printed at full double precision of course, but an optimal algorithm is used...

Webmachine drops http/1.1 connections on POST request failure when tracing is enabled

This appears to be a timing related issue, I can reproduce this as-is but not with a larger body: ``` erlang -define(SAMPLE_JSON_CONTENT, "{\"hello\":\"world" ++ string:copies(" ", 8192) ++ "\"}"). ```...