excalidocker-rs icon indicating copy to clipboard operation
excalidocker-rs copied to clipboard

Support `extends` fully

Open rmoff opened this issue 2 years ago • 6 comments

For example:

docker run --rm -e INPUT_PATH=https://raw.githubusercontent.com/treeverse/lakeFS-samples/main/standalone/airflow-dag-example/docker-compose.yml etolbakov/excalidocker:latest > tmp.excalidraw

The generated diagram doesn't show the ports exposed by the services that are extended from a parent Docker Compose, only those in the Docker Compose specified

CleanShot_2023-06-14_at_11 06 55@2x

Also odd how they're all rendered at an increasing vertical offset, not sure if this is by design but keeping it level would be useful too

rmoff avatar Jun 14 '23 10:06 rmoff

@rmoff Thanks for the feedback and the very interesting usecase! I'll consider giving it a go! In terms of the vertical offset - yes, that's by design (that's actually the reason why I'm doing backend 😆). Did I get you right that it will be fine to only horizontal offset and zero vertical?

https://github.com/etolbakov/excalidocker-rs/pull/25

etolbakov avatar Jun 14 '23 11:06 etolbakov

@rmoff sharing with you the result of the fix. Screenshot 2023-06-16 at 23 28 03 I'm going to create a new release sometime this weekend. Interested in your feedback

etolbakov avatar Jun 16 '23 22:06 etolbakov

Extends

Some way of indicating containers that extend another compose would be useful, e.g. a shaded box

tmp

Alignment

I think it would be a useful flag so the user can choose stepped (as currently), or vertical align, or horizontal (all three are useful)

It might also be useful to have a 'compact' option which would stack containers (for inline documentation limiting the horizontal space is the usecase here), something like:

image

rmoff avatar Jun 19 '23 08:06 rmoff

Great, thanks for the feedback Robin! I will consider implementing these features.

etolbakov avatar Jun 19 '23 11:06 etolbakov

Regarding the shaded box I was thinking to use that for network representation (https://github.com/etolbakov/excalidocker-rs/issues/15). So probably need to think about it more. Maybe network could be transparent dashed rectangle with some text in the corner.

the user can choose stepped (as currently), or vertical align, or horizontal (all three are useful)

I really like this idea, need to see how much time will it take to implement. That moment when you'd like to blame the previous developer for not extensible code ... and realize that it's actually yourself 😅

etolbakov avatar Jun 19 '23 20:06 etolbakov

@rmoff As a part of https://github.com/etolbakov/excalidocker-rs/pull/30 I did alignment support (available modes horizontal, vertical and stepped). Could you please share your feedback when you try them?

etolbakov avatar Jul 03 '23 21:07 etolbakov