Metrics.NET
Metrics.NET copied to clipboard
InfluxDB
I've been playing with the latest InfluxDB, the api has change significantly breaking the current metrics.net influxdb reporter. I'm going to start updating this but before I do how do you foresee managing multiple versions? Do we just have a MetricsReport extensions for each version or maybe separate reporters out to their own assembly?
Since InfluxDB is pre 1.0 version, and api changes are frequent, I would not bother maintaining compatibility with older versions too much. If there is interest in a specific version, or if a version is rather wide-spread then maybe ... but I don't think that is the case with InfluxDB for now.
After 1.0 release it makes sense to have multiple extension method, or maybe a parameter where the user can specify the version.
As long as there are no external dependencies required, I rather keep this reporters in the core library for discover-ability reasons - but I really don't have a strong opinion about this. Maybe initially developed as a separate assembly and merge when dev complete...
Thanks
Hi Allan,
Can you let me know what is your progress on influxdb reporter? I am interested in making it work with InfluxDB 0.9. Perhaps we can join forces on that.
+1
I've opened a PR (https://github.com/etishor/Metrics.NET/pull/110) that implements the new InfluxDB line protocol.
@etishor Thoughts on PR https://github.com/etishor/Metrics.NET/pull/110? If you're not worried about backwards compatibility until InfluxDB hits 1.0, should be okay to merge? Thanks!
FYI -- published this to Nuget.org @ https://www.nuget.org/packages/Metrics.NET.InfluxDB/