pysnmp icon indicating copy to clipboard operation
pysnmp copied to clipboard

unmakeVarBinds shouldn't not ignore errors

Open therve opened this issue 5 years ago • 1 comments

In that commit: https://github.com/etingof/pysnmp/commit/e8fa401677432e4e48d1a9c36b996ef94b043d90#diff-dfd8cef40427a8ae7a84575d7e419aa7R74 unmakeVarBinds was not change to pass ignoreErrors=False.

It seems like a backward incompatible change. Overall, I feel that resolveWithMib should have had False as a default from the beginning, but maybe it's too late.

therve avatar Dec 11 '19 14:12 therve

This was an intentional change made by Ilya, if you read the comments of that commit,

This change tightens outgoing objects MIB compliance (send will fail), but tolerate non quite compliant objects we receive.

Since unmakeVarBinds are only used on received messages, it makes sense to use ignoreErrors=True.

Anyway this flag isn't very useful based on my observations.

lextm avatar Aug 26 '24 07:08 lextm