Etienne Schalk

Results 33 comments of Etienne Schalk

Hello, I started digging into this but kind of get lost into the code. So, I changed approach. I assume that the weighted reductions behaviours should be aligned as much...

The PR suggests using the proposed `join='strict'` kwarg. [`test_concat_join_coordinate_variables_non_asked_dims`](https://github.com/pydata/xarray/pull/8698/files#diff-013240d9a2962f162c160fad188b4ce7c93d599692750ccdee3fde00813f86b5R1267) tests: ```python ds1 = xr.Dataset( coords={ 'x_center': ('x_center', [1, 2, 3]), 'x_outer': ('x_outer', [0.5, 1.5, 2.5, 3.5]), }, ) ``` `xr.concat([ds1,...

Indeed join='exact' raises an error: ```python import xarray as xr ds1 = xr.Dataset( coords={ 'x_center': ('x_center', [1, 2, 3]), 'x_outer': ('x_outer', [0.5, 1.5, 2.5, 3.5]), }, ) ds2 = xr.Dataset(...

Note: this issue was generated from a [notebook](https://github.com/etienneschalk/datatree-experimentation/blob/main/notebooks/unexpected-behaviour-dt-from-ds.ipynb). You can use it to reproduce locally the bug.

https://github.com/xarray-contrib/datatree/issues/311#issuecomment-1944364934 Hello, thanks for your answer! Indeed the round-trip capability seems the cleanest default behaviour. A Dataset is supposed to be a group. I think what I needed already exists:...

Complement: After re-reading all of this, I think the most natural behaviour from a user perspective is the one of `__setitem__`: ```python xdt = dt.DataTree() for varname, xda in xds.items():...

Okay for adding the offending variable names! I completely agree with the "one dataset per group" logic. This is more from a usage perspective where I find these 3 lines...

I remained conservative and forbid the renaming of a node to None if it has a parent _Edit: according to a comment in the datatree design document mentioned in https://github.com/pydata/xarray/issues/8747,...

Hello @TomNicholas In the context of merging datatree into xarray, should new developments continue to be made on this repo, or in the xarray repo? Or is there a code...

What should be the expected behaviour when renaming a child node to None? I had a look at how xarray behaves when renaming a DataArray inside of a Dataset. It...