Etienne dg

The biggest advantage of Simon's is that the neighbors are already sorted, so it is much less costly to build the adjacency lists. No matter what, with this approach, we...

Simon's, but replacing the call to `_sample_with_replacement!` by `randsubseq!`, so does not improve. ``` 217.053 μs (504 allocations: 77.73 KiB) 3.721 ms (504 allocations: 1.02 MiB) 4.865 ms (535 allocations:...

There is a gotcha in your implementation, the adjacency lists are not sorted... (This is a requirement for `SimpleGraph`). So you indeed have to pay more to sort the adjacency...

Well, in fact it was not only the mod1 that caused vertices to not be sorted. Using your old definition of trianglemap (which follows simon's ordering), I was able to...

Very good question, for the moment, the `collect_if_not_vector` sounds like the best workaround but feels a bit clunky, maybe it can be refined by checking outneighbors implement indexing methods ?

@gdalle Should be good for review. Do you know what's wrong with the documentation?

You can open a pull request if you have an implementation. Improving the tests of the other centrality measures is of course welcome. We don't have tests on Graphs.jl that...

Note that for the moment, this library lacks even the most basic functionalities for planarity and embeddings (which is welcome contribution, of course) although something was started here: https://github.com/JuliaGraphs/Graphs.jl/pull/208

This is expected to add this kind of function in the API for the 2.0, see https://github.com/JuliaGraphs/Graphs.jl/issues/146

@gdalle This should be ready for review. I'm unable to reach this last branch for codecov **Edit:** This is triggered non-deterministically and very rarely, I don't think it makes sense...