Mapify icon indicating copy to clipboard operation
Mapify copied to clipboard

Support circle areas

Open brockfanning opened this issue 8 years ago • 8 comments

This library already supports rect and poly areas, but doesn't support the last type: circle. Adding this support is not trivial, but not impossible. I could go ahead and give it a shot. However if any big changes are in the works, I might wait until things settle. @etienne-martin do you think it's appropriate to work on this feature now?

brockfanning avatar Nov 29 '16 14:11 brockfanning

You're good to go, I just merged some recent changes.

We're not working on new features right now.

Thanks for your help.

etienne-martin avatar Nov 30 '16 02:11 etienne-martin

Does library support circles area now?

andreys42 avatar Jun 18 '19 09:06 andreys42

@andrey290494 I put up my attempt at this as a pull request. I'm not sure if there have been any developments in the meantime.

brockfanning avatar Jun 18 '19 19:06 brockfanning

@etienne-martin , @brockfanning, any ideas on how to implement such ability to library? Circles area supporting will make this lib much usefull

andreys42 avatar Jun 20 '19 07:06 andreys42

@andrey290494 My PR for this is still up: #23

brockfanning avatar Jun 20 '19 09:06 brockfanning

@brockfanning it's strange. I'm updated mapify.js using your PR changes. Now circle areas appears, but popover appears not in a circle. Looks like popover coords calculated wrong

andreys42 avatar Jun 20 '19 11:06 andreys42

@andrey290494 Ah, OK, yes I don't recall testing with popovers. I don't have much bandwidth to continue with this, so hopefully you have time to experiment with a solution.

brockfanning avatar Jun 20 '19 11:06 brockfanning

@brockfanning, OK, will try

andreys42 avatar Jun 20 '19 12:06 andreys42