Dave Hall

Results 211 comments of Dave Hall

As you can probably tell, this project isn't exactly humming with activity at the moment, so don't expect anything to be removed at any time soon. :)

I think we need a solution like in `django-reversion`. When registering, you can pass `for_concrete_model`: https://github.com/etianen/django-reversion/blob/master/reversion/revisions.py#L369 The rest of `django-historylinks` would then respect this setting WRT permissions and generic relations.

I think `doctest` is already supported. Check this out: ``` py import doctest import logging logger = logging.getLogger(__name__) def foo() -> None: """ This is foo. >>> foo() >>> logot.assert_logged(logged.info("foo"))...

Looking at the `doctest` source, it seems hard/impossible to write an extension for it, as it has no plugin system like `pytest`, and no way of mixing in a test...

Hmm. So maybe it would be possible to have an api like: ```py logot = Logot.get_current() ``` This would return a reference to the `logot` instance that's currently capturing logs....

Alternatively, a `LogotDoctestRunner` subclass that injected an initialized logot would be possible too. But that would be useless with `pytest` doctest runners and higher-level doctest APIs. `doctest` is frustrating, because...

This is actually a bad idea. Should multiplying a log pattern join them with `>>` or `&`? It's unclear.

Increasingly I think this is useful, and should join log patterns with the `>>` operator.

Nice to hear! I'll have a go at an implementation when I next have time.