ethzasl_msf icon indicating copy to clipboard operation
ethzasl_msf copied to clipboard

Published 20 hours ago • verified publisher icon ethz-asl

consistent notation

Open otim opened this issue 10 years ago • 7 comments

otim avatar Jun 08 '15 12:06 otim

@otim thanks for the nice cleanup. lgtm.

simonlynen avatar Jun 08 '15 12:06 simonlynen

I found another occurence of Eigen::Matrix<double, 3, 3> C_q = state.Get<StateDefinition_T::q>().conjugate().toRotationMatrix(); with the conjugate in spherical_measurement.h... Probably we should change it there as well, but I did not feel like it just now. This is a mess :(

otim avatar Jun 08 '15 16:06 otim

I just tested with both pose measurements and position measurements and everything still looks good. please take a look at the latest changes and pay extra attention to things related to spherical measurements and pressure sensor, as I am not able to test these. Thanks!

otim avatar Jun 15 '15 15:06 otim

@burrimi could you take a look at getting this one into master after testing?

simonlynen avatar Jan 20 '16 05:01 simonlynen

+1

v0n0 avatar Jan 22 '16 23:01 v0n0

What would it take to test this one?

v0n0 avatar Jan 29 '16 23:01 v0n0

@marija-p I saw that you recently took on the task of merging PRs, do you think you could also merge this one? Thanks!

v0n0 avatar Apr 07 '16 04:04 v0n0