fidesops icon indicating copy to clipboard operation
fidesops copied to clipboard

[DX Enhancement] Add warnings to Fidesops Dataset validation

Open seanpreston opened this issue 3 years ago • 1 comments

Is your feature request related to a specific problem?

Fidesops dataset validation must allow certain configurations to pass that may not be constructive to the end user if not intentional. For example: Fidesops will allow you to configure a collection within a dataset with no primary key, however without a primary key Fidesops cannot perform erasures.

Describe the solution you'd like

In the scenario above, FIdesops should publish a warning in the logs that the Dataset has been saved, but no erasure will be possible on the tables where a primary key is omitted.

Describe alternatives you've considered, if any

Other scenarios to warn on include (but aren't limited to):

  • Data category is under fidesops_meta instead of nested under the field
  • No data type defined on a field, so we can’t do any type coercion

Additional context

@adriaaaa / @iamkelllly / @pattisdr — are you aware of any other edge cases here?

seanpreston avatar Feb 23 '22 18:02 seanpreston

Thanks for making this ticket @seanpreston!

pattisdr avatar Feb 23 '22 18:02 pattisdr