fides icon indicating copy to clipboard operation
fides copied to clipboard

`fides push --diff` always shows a diff, even if the object hasn't actually changed

Open ThomasLaPiana opened this issue 3 years ago • 0 comments

Bug Description

Diff is returning false positive changes

Steps to Reproduce

  1. fides push --diff
  2. fides push --diff but notice that the system object thinks there have been a change

Expected behavior

Double pushing should show no diff!

Additional context

This is related to the diffing algorithm, and the fact that it specifically isn't handling complex objects correctly. On potential solution would be to convert both objects into their proper fideslang models, and then back to a dict for comparison?

ThomasLaPiana avatar Aug 15 '22 09:08 ThomasLaPiana