fides
fides copied to clipboard
Dirty version in wheels may be fixed by removing egg info exception from gitignore
Is your feature request related to a specific problem?
We had a problem where versioneer would mark our built wheel as dirty, which was solved in this PR: https://github.com/ethyca/fides/pull/962
However, there may be a cleaner solution available if we remove the egg info exception from gitignore. This was first added to deal with docker mounting, but we can actually exclude a file from a mount, which may be a cleaner solution that could solve this problem too.
Describe the solution you'd like
- Remove egg info from git ignore exception
- Add a docker volume mount exception for the egg info
- Remove the
git reset --hard
step added in https://github.com/ethyca/fides/pull/962
Describe alternatives you've considered, if any
This is low priority since the solution implemented in https://github.com/ethyca/fides/pull/962 does work
Additional context
https://github.com/ethyca/fides/pull/962#issuecomment-1210741886