fides icon indicating copy to clipboard operation
fides copied to clipboard

Prepend `ctl` to database table names

Open ThomasLaPiana opened this issue 3 years ago • 1 comments

Closes #978

Code Changes

  • [x] update sqlmodels.py to prepend all tables with ctl
  • [x] create an alembic migration to rename the tables and indexes
  • [x] update past migrations that get broken by the new change

Steps to Confirm

  • [ ] automated tests pass

Pre-Merge Checklist

  • [x] All CI Pipelines Succeeded
  • Documentation Updated:
    • [x] documentation complete, or draft/outline provided (tag docs-team to complete/review on this branch)
    • [ ] documentation issue created (tag docs-team to complete issue separately)
  • [x] Issue Requirements are Met
  • [ ] ~~Relevant Follow-Up Issues Created~~
  • [x] Update CHANGELOG.md

Description Of Changes

(Relatively) Straightforward PR to avoid name collisions with ops

ThomasLaPiana avatar Aug 11 '22 07:08 ThomasLaPiana

everything looking good, last piece is to update the migration to also rename the indexes

ThomasLaPiana avatar Aug 15 '22 13:08 ThomasLaPiana

Fixed merge conflicts and merged alembic heads

allisonking avatar Aug 17 '22 19:08 allisonking