fides icon indicating copy to clipboard operation
fides copied to clipboard

configure_db failing silently

Open sanders41 opened this issue 3 years ago • 0 comments

Bug Description

In working through some migrations issues @earmenda and I noticed that when a migration fails configure_db will report that the database was initialized, even when migrations fail and therefore the database is not ready.

Steps to Reproduce

  1. Create a migration that generates and error.
  2. Run fidesctl db init
  3. Check the console output. It will say the initialization was successful.
{
  "data": {
    "message": "Fidesctl database initialized"
  }
}
  1. Check the docker log docker logs {container id}. It will show the error.
2022-07-15 20:18:17.657 [ERROR] (main:configure_db:56): Unable to configure database: KeyError: 'client_detail'

Expected behavior

fidesctl database init should write the error to the console rather than show the database was successfully initialized.

Screenshots

If applicable, add screenshots to help explain your problem.

Environment

  • Version: 1.7.0
  • OS: MacOS
  • Python Version: 3.8.13
  • Docker Version: Docker version 20.10.17, build 100c701

Additional context

Add any other context about the problem here.

sanders41 avatar Jul 15 '22 20:07 sanders41