refactor: resource status labels [ENG-2060]
Ticket ENG-2060
Description Of Changes
Update to the resource status labels displayed to users.
Code Changes
- Updated the
RESOURCE_STATUSconst with the new FE status names. - Updated
MONITOR_UPDATE_NAMESmap to maintain consistency with the resource status naming - Updated
CatalogResourceStatusenum to match the resource status updates
Steps to Confirm
- Visit the Action Center screen
- Confirm that monitor statuses now include
Classifiedinstead ofIn Review - Navigate to a monitor tree view screen
- Confirm that the new labels have been applied for each of the new status labels:
- In Review -> Classified
- Approved -> Reviewed
- Confirming -> Approving
- Confirmed -> Approved
Pre-Merge Checklist
- [x] Issue requirements met
- [x] All CI pipelines succeeded
- [x]
CHANGELOG.mdupdated- [ ] Add a https://github.com/ethyca/fides/labels/db-migration label to the entry if your change includes a DB migration
- [ ] Add a https://github.com/ethyca/fides/labels/high-risk label to the entry if your change includes a high-risk change (i.e. potential for performance impact or unexpected regression) that should be flagged
- [ ] Updates unreleased work already in Changelog, no new entry necessary
- UX feedback:
- [ ] All UX related changes have been reviewed by a designer
- [ ] No UX review needed
- Followup issues:
- [ ] Followup issues created
- [ ] No followup issues
- Database migrations:
- [ ] Ensure that your downrev is up to date with the latest revision on
main - [ ] Ensure that your
downgrade()migration is correct and works- [ ] If a downgrade migration is not possible for this change, please call this out in the PR description!
- [ ] No migrations
- [ ] Ensure that your downrev is up to date with the latest revision on
- Documentation:
- [ ] Documentation complete, PR opened in fidesdocs
- [ ] Documentation issue created in fidesdocs
- [ ] If there are any new client scopes created as part of the pull request, remember to update public-facing documentation that references our scope registry
- [ ] No documentation updates required
The latest updates on your projects. Learn more about Vercel for GitHub.
| Project | Deployment | Review | Updated (UTC) |
|---|---|---|---|
| fides-plus-nightly | Preview, Comment | Dec 17, 2025 8:55pm |
1 Skipped Deployment
| Project | Deployment | Review | Updated (UTC) |
|---|---|---|---|
| fides-privacy-center | Dec 17, 2025 8:55pm |
Greptile Overview
Greptile Summary
Refactored resource status labels across the Action Center and Data Catalog features to improve clarity for users.
Key changes:
In Review→ClassifiedApproved→ReviewedConfirming...→Approving...Confirmed→ApprovedClassifying→Classifying...(added ellipsis for consistency with other in-progress states)
Updated corresponding CatalogResourceStatus enum values, MONITOR_UPDATE_NAMES mappings, status label arrays, diff status mappings, and test assertions. The changes maintain consistency across frontend components, constants, and E2E tests.
Issue found:
- Inconsistent labeling in
CatalogResourceStatus.CLASSIFYING- uses"Classifying"without ellipsis whileMonitorFields.const.tsuses"Classifying..."with ellipsis for the same status
Confidence Score: 4/5
- Safe to merge after fixing the labeling inconsistency
- The refactor is thorough and systematic, with all references properly updated across components, constants, and tests. However, there's an inconsistency with the "Classifying" label that should be fixed to maintain consistency with other in-progress status labels (which use ellipsis)
- clients/admin-ui/src/features/data-catalog/utils.ts requires attention to fix the CLASSIFYING label inconsistency
Important Files Changed
File Analysis
| Filename | Score | Overview |
|---|---|---|
| clients/admin-ui/src/features/data-catalog/utils.ts | 4/5 | Updated enum values: IN_REVIEW → CLASSIFIED, APPROVED → REVIEWED; inconsistent CLASSIFYING label (no ellipsis) |
| clients/admin-ui/src/features/data-discovery-and-detection/action-center/constants.ts | 5/5 | Updated display names in MONITOR_UPDATE_NAMES map for consistency |
| clients/admin-ui/src/features/data-discovery-and-detection/action-center/fields/MonitorFields.const.ts | 5/5 | Updated resource status labels, mappings, and excluded filter statuses with new naming convention |
@speaker-ender Question, is there a reason for Approved to have 2 labels?
Also I was confused in this case because the label for the ✔️ action is "Confirm". Approved isn't the new label for Confirm?
Reference link I was viewing: https://fides-plus-nightly-git-refactor-resource-status-labels-ethyca.vercel.app/data-discovery/action-center/datastore/Test_LLM_Monitor_1765469854823?resourceStatus=Unlabeled,Classifying...,Classified,Reviewed,Removed,Error,Approved&dataCategory=&confidenceBucket=
@speaker-ender Question, is there a reason for Approved to have 2 labels?
That would be an oversight that I think I fixed
Also I was confused in this case because the label for the ✔️ action is "Confirm". Approved isn't the new label for Confirm?
Ah yes the action names and other related labels should change to reduce confusion.
I'm going to get some other eyes on this as well to make sure all the copy is updated appropriately.
@lucanovera this is good for another quick code review