fides icon indicating copy to clipboard operation
fides copied to clipboard

refactor: resource status labels [ENG-2060]

Open speaker-ender opened this issue 1 month ago • 4 comments

Ticket ENG-2060

Description Of Changes

Update to the resource status labels displayed to users.

Code Changes

  • Updated the RESOURCE_STATUS const with the new FE status names.
  • Updated MONITOR_UPDATE_NAMES map to maintain consistency with the resource status naming
  • Updated CatalogResourceStatus enum to match the resource status updates

Steps to Confirm

  1. Visit the Action Center screen
  2. Confirm that monitor statuses now include Classified instead of In Review
  3. Navigate to a monitor tree view screen
  4. Confirm that the new labels have been applied for each of the new status labels:
  • In Review -> Classified
  • Approved -> Reviewed
  • Confirming -> Approving
  • Confirmed -> Approved

Pre-Merge Checklist

  • [x] Issue requirements met
  • [x] All CI pipelines succeeded
  • [x] CHANGELOG.md updated
    • [ ] Add a https://github.com/ethyca/fides/labels/db-migration label to the entry if your change includes a DB migration
    • [ ] Add a https://github.com/ethyca/fides/labels/high-risk label to the entry if your change includes a high-risk change (i.e. potential for performance impact or unexpected regression) that should be flagged
    • [ ] Updates unreleased work already in Changelog, no new entry necessary
  • UX feedback:
    • [ ] All UX related changes have been reviewed by a designer
    • [ ] No UX review needed
  • Followup issues:
    • [ ] Followup issues created
    • [ ] No followup issues
  • Database migrations:
    • [ ] Ensure that your downrev is up to date with the latest revision on main
    • [ ] Ensure that your downgrade() migration is correct and works
      • [ ] If a downgrade migration is not possible for this change, please call this out in the PR description!
    • [ ] No migrations
  • Documentation:
    • [ ] Documentation complete, PR opened in fidesdocs
    • [ ] Documentation issue created in fidesdocs
    • [ ] If there are any new client scopes created as part of the pull request, remember to update public-facing documentation that references our scope registry
    • [ ] No documentation updates required

speaker-ender avatar Dec 10 '25 14:12 speaker-ender

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Review Updated (UTC)
fides-plus-nightly Ready Ready Preview, Comment Dec 17, 2025 8:55pm
1 Skipped Deployment
Project Deployment Review Updated (UTC)
fides-privacy-center Ignored Ignored Dec 17, 2025 8:55pm

vercel[bot] avatar Dec 10 '25 14:12 vercel[bot]

Greptile Overview

Greptile Summary

Refactored resource status labels across the Action Center and Data Catalog features to improve clarity for users.

Key changes:

  • In ReviewClassified
  • ApprovedReviewed
  • Confirming...Approving...
  • ConfirmedApproved
  • ClassifyingClassifying... (added ellipsis for consistency with other in-progress states)

Updated corresponding CatalogResourceStatus enum values, MONITOR_UPDATE_NAMES mappings, status label arrays, diff status mappings, and test assertions. The changes maintain consistency across frontend components, constants, and E2E tests.

Issue found:

  • Inconsistent labeling in CatalogResourceStatus.CLASSIFYING - uses "Classifying" without ellipsis while MonitorFields.const.ts uses "Classifying..." with ellipsis for the same status

Confidence Score: 4/5

  • Safe to merge after fixing the labeling inconsistency
  • The refactor is thorough and systematic, with all references properly updated across components, constants, and tests. However, there's an inconsistency with the "Classifying" label that should be fixed to maintain consistency with other in-progress status labels (which use ellipsis)
  • clients/admin-ui/src/features/data-catalog/utils.ts requires attention to fix the CLASSIFYING label inconsistency

Important Files Changed

File Analysis

Filename Score Overview
clients/admin-ui/src/features/data-catalog/utils.ts 4/5 Updated enum values: IN_REVIEW → CLASSIFIED, APPROVED → REVIEWED; inconsistent CLASSIFYING label (no ellipsis)
clients/admin-ui/src/features/data-discovery-and-detection/action-center/constants.ts 5/5 Updated display names in MONITOR_UPDATE_NAMES map for consistency
clients/admin-ui/src/features/data-discovery-and-detection/action-center/fields/MonitorFields.const.ts 5/5 Updated resource status labels, mappings, and excluded filter statuses with new naming convention

greptile-apps[bot] avatar Dec 10 '25 22:12 greptile-apps[bot]

@speaker-ender Question, is there a reason for Approved to have 2 labels? Captura de pantalla 2025-12-11 a la(s) 1 24 19 p  m

Also I was confused in this case because the label for the ✔️ action is "Confirm". Approved isn't the new label for Confirm? Captura de pantalla 2025-12-11 a la(s) 1 29 17 p  m

Reference link I was viewing: https://fides-plus-nightly-git-refactor-resource-status-labels-ethyca.vercel.app/data-discovery/action-center/datastore/Test_LLM_Monitor_1765469854823?resourceStatus=Unlabeled,Classifying...,Classified,Reviewed,Removed,Error,Approved&dataCategory=&confidenceBucket=

lucanovera avatar Dec 11 '25 16:12 lucanovera

@speaker-ender Question, is there a reason for Approved to have 2 labels?

That would be an oversight that I think I fixed

Also I was confused in this case because the label for the ✔️ action is "Confirm". Approved isn't the new label for Confirm?

Ah yes the action names and other related labels should change to reduce confusion.

I'm going to get some other eyes on this as well to make sure all the copy is updated appropriately.

speaker-ender avatar Dec 11 '25 21:12 speaker-ender

@lucanovera this is good for another quick code review

speaker-ender avatar Dec 17 '25 17:12 speaker-ender