fides icon indicating copy to clipboard operation
fides copied to clipboard

Fixing system group reactivation

Open galvana opened this issue 4 months ago • 2 comments

Closes []

Description Of Changes

Write some things here about the changes and any potential caveats

Code Changes

  • list your code changes here

Steps to Confirm

  1. list any manual steps for reviewers to confirm the changes

Pre-Merge Checklist

  • [ ] Issue requirements met
  • [ ] All CI pipelines succeeded
  • [ ] CHANGELOG.md updated
    • [ ] Add a https://github.com/ethyca/fides/labels/db-migration label to the entry if your change includes a DB migration
    • [ ] Add a https://github.com/ethyca/fides/labels/high-risk label to the entry if your change includes a high-risk change (i.e. potential for performance impact or unexpected regression) that should be flagged
    • [ ] Updates unreleased work already in Changelog, no new entry necessary
  • Followup issues:
    • [ ] Followup issues created
    • [ ] No followup issues
  • Database migrations:
    • [ ] Ensure that your downrev is up to date with the latest revision on main
    • [ ] Ensure that your downgrade() migration is correct and works
      • [ ] If a downgrade migration is not possible for this change, please call this out in the PR description!
    • [ ] No migrations
  • Documentation:
    • [ ] Documentation complete, PR opened in fidesdocs
    • [ ] Documentation issue created in fidesdocs
    • [ ] If there are any new client scopes created as part of the pull request, remember to update public-facing documentation that references our scope registry
    • [ ] No documentation updates required

galvana avatar Sep 10 '25 01:09 galvana

The latest updates on your projects. Learn more about Vercel for GitHub.

2 Skipped Deployments
Project Deployment Preview Comments Updated (UTC)
fides-plus-nightly Ignored Ignored Sep 10, 2025 1:32am
fides-privacy-center Ignored Ignored Sep 10, 2025 1:32am

vercel[bot] avatar Sep 10 '25 01:09 vercel[bot]

Codecov Report

:x: Patch coverage is 36.66667% with 19 lines in your changes missing coverage. Please review. :white_check_mark: Project coverage is 87.14%. Comparing base (ecb8cc3) to head (bdec376).

Files with missing lines Patch % Lines
src/fides/service/taxonomy/utils.py 36.66% 12 Missing and 7 partials :warning:
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6568      +/-   ##
==========================================
- Coverage   87.52%   87.14%   -0.38%     
==========================================
  Files         496      496              
  Lines       31772    31796      +24     
  Branches     3612     3622      +10     
==========================================
- Hits        27807    27708      -99     
- Misses       3170     3281     +111     
- Partials      795      807      +12     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

:rocket: New features to boost your workflow:
  • :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • :package: JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

codecov[bot] avatar Sep 10 '25 01:09 codecov[bot]